[incubator-pinot] 03/03: refactor

[jihao]

This is an automated email from the ASF dual-hosted git repository.

jihao pushed a commit to branch severity-alerter
in repository https://gitbox.apache.org/repos/asf/incubator-pinot.git

commit 55117218c4008a8d5a3893f0b29892a52e5d9608
Author: Jihao Zhang <jihzh...@linkedin.com>
AuthorDate: Wed Sep 2 10:08:02 2020 -0700

    refactor
---
 .../detection/DetectionPipelineTaskRunner.java     | 34 ++++++++++++----------
 1 file changed, 19 insertions(+), 15 deletions(-)

diff --git 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
index 183be6f..32bb024 100644
--- 
a/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
+++ 
b/thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/DetectionPipelineTaskRunner.java
@@ -179,21 +179,7 @@ public class DetectionPipelineTaskRunner implements 
TaskRunner {
       for (MergedAnomalyResultDTO anomaly : result.getAnomalies()) {
         // if an anomaly should be re-notified, update the notification lookup 
table in the database
         if (anomaly.shouldRenotify()) {
-          List<AnomalySubscriptionGroupNotificationDTO> 
subscriptionGroupNotificationDTOs =
-              
this.anomalySubscriptionGroupNotificationDAO.findByPredicate(Predicate.EQ("anomalyId",
 anomaly.getId()));
-          AnomalySubscriptionGroupNotificationDTO anomalyNotificationDTO;
-          if (subscriptionGroupNotificationDTOs.isEmpty()) {
-            // create a new record if it is not existed yet.
-            anomalyNotificationDTO = new 
AnomalySubscriptionGroupNotificationDTO();
-            new AnomalySubscriptionGroupNotificationDTO();
-            anomalyNotificationDTO.setAnomalyId(anomaly.getId());
-            
anomalyNotificationDTO.setDetectionConfigId(anomaly.getDetectionConfigId());
-          } else {
-            // update the existing record if the anomaly needs to be 
re-notified
-            anomalyNotificationDTO = subscriptionGroupNotificationDTOs.get(0);
-            
anomalyNotificationDTO.setNotifiedSubscriptionGroupIds(Collections.emptyList());
-          }
-          
this.anomalySubscriptionGroupNotificationDAO.save(anomalyNotificationDTO);
+          renotifyAnomaly(anomaly);
         }
       }
 
@@ -206,4 +192,22 @@ public class DetectionPipelineTaskRunner implements 
TaskRunner {
       throw e;
     }
   }
+
+  private void renotifyAnomaly(MergedAnomalyResultDTO anomaly) {
+    List<AnomalySubscriptionGroupNotificationDTO> 
subscriptionGroupNotificationDTOs =
+        
this.anomalySubscriptionGroupNotificationDAO.findByPredicate(Predicate.EQ("anomalyId",
 anomaly.getId()));
+    AnomalySubscriptionGroupNotificationDTO anomalyNotificationDTO;
+    if (subscriptionGroupNotificationDTOs.isEmpty()) {
+      // create a new record if it is not existed yet.
+      anomalyNotificationDTO = new AnomalySubscriptionGroupNotificationDTO();
+      new AnomalySubscriptionGroupNotificationDTO();
+      anomalyNotificationDTO.setAnomalyId(anomaly.getId());
+      
anomalyNotificationDTO.setDetectionConfigId(anomaly.getDetectionConfigId());
+    } else {
+      // update the existing record if the anomaly needs to be re-notified
+      anomalyNotificationDTO = subscriptionGroupNotificationDTOs.get(0);
+      
anomalyNotificationDTO.setNotifiedSubscriptionGroupIds(Collections.emptyList());
+    }
+    this.anomalySubscriptionGroupNotificationDAO.save(anomalyNotificationDTO);
+  }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org