Jackie-Jiang commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1569749650
##########
pinot-common/src/main/codegen/includes/parserImpls.ftl:
##########
@@ -109,3 +109,14 @@ SqlNode SqlPhysicalExplain() :
nDynamicParams);
}
}
+SqlNode SqlShowTables() :
+{
+ SqlParserPos pos;
+}
+{
+ <SHOW> { pos = getPos(); }
Review Comment:
Do we need to modify the parser? Is there a standard SQL way of showing
tables?
##########
pinot-common/src/thrift/query.thrift:
##########
@@ -32,6 +32,8 @@ struct PinotQuery {
11: optional map<string, string> queryOptions;
12: optional bool explain;
13: optional map<Expression, Expression> expressionOverrideHints;
+ 14: optional bool showTables;
Review Comment:
Do we need to add it into `PinotQuery`? I don't think we need to send the
request to server. Ideally we can get this info from the parsed `PlanNode`
without constructing the `PinotQuery`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
