KKcorps commented on PR #13015: URL: https://github.com/apache/pinot/pull/13015#issuecomment-2082652122
> There is no guarantee we can always detect gap with start offset and batch first offset, especially after we introduce the exclusive start offset concept. Seems like we still want to report gap within the general handling flow. In that case it should be easier to add an API `hasGap()` into `MessageBatch`, which can be filled by the stream consumer That makes sense since we already have the information in the consumer from which offset did we actually wanted to consume the data vs from which offset we actually did OR any other criteria which consumer wants to implement -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
