deemoliu commented on PR #13005: URL: https://github.com/apache/pinot/pull/13005#issuecomment-2083901849
+1 on making this configurable in the first version. And this change, it will be easier for us to benchmark with different library. There are some known cases re2j doesn't outperform the current implementation, so it's a good idea to on hold the replacement of the existing library. We can do another thorough analysis on when re2j is more efficient and when it's not, and make a proposal on the default behavior of regex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
