poorbarcode commented on code in PR #20583:
URL: https://github.com/apache/pulsar/pull/20583#discussion_r1231960811
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/ServerCnx.java:
##########
@@ -1184,7 +1184,6 @@ protected void handleSubscribe(final CommandSubscribe
subscribe) {
ServerError error =
getErrorCodeWithErrorLog(existingConsumerFuture, true,
String.format("Consumer subscribe failure.
remoteAddress: %s, subscription: %s",
remoteAddress, subscriptionName));
- consumers.remove(consumerId, existingConsumerFuture);
Review Comment:
BTW, there is a PR trying to fix the concurrent call `subscribe` in the same
client
- https://github.com/apache/pulsar/pull/20591
I still think the current PR is trying to solve this issue is meaningful,
and it would be nice to have a test that can reproduce it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
