wolfstudy commented on a change in pull request #660: URL: https://github.com/apache/pulsar-client-go/pull/660#discussion_r743352353
########## File path: pulsar/negative_backoff_policy.go ########## @@ -0,0 +1,46 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package pulsar + +import "math" + +// NackBackoffPolicy is a interface for custom message negativeAcked policy, users can specify a NackBackoffPolicy +// for a consumer. +// +// > Notice: the consumer crashes will trigger the redelivery of the unacked message, this case will not respect the +// > NackBackoffPolicy, which means the message might get redelivered earlier than the delay time +// > from the backoff. +type NackBackoffPolicy interface { + // The redeliveryCount indicates the number of times the message was redelivered. + // We can get the redeliveryCount from the CommandMessage. + Next(redeliveryCount uint32) int64 +} + +// defaultNackBackoffPolicy is default impl for NackBackoffPolicy. +type defaultNackBackoffPolicy struct{} + +func (nbp *defaultNackBackoffPolicy) Next(redeliveryCount uint32) int64 { + minNackTimeMs := int64(1000 * 10) // 10sec + maxNackTimeMs := 1000 * 60 * 10 // 10min + + if redeliveryCount < 0 { + return minNackTimeMs + } + + return int64(math.Min(math.Abs(float64(minNackTimeMs<<redeliveryCount)), float64(maxNackTimeMs))) Review comment: Sure, will add comment for this change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
