[ https://issues.apache.org/jira/browse/HADOOP-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055090#comment-16055090 ]
Weisen Han commented on HADOOP-14533: ------------------------------------- Thanks for your review, [~vagarychen]. submit the patch as you suggested. > TraceAdmin#run, the size of args cannot be less than zero,which is a linklist > ----------------------------------------------------------------------------- > > Key: HADOOP-14533 > URL: https://issues.apache.org/jira/browse/HADOOP-14533 > Project: Hadoop Common > Issue Type: Bug > Components: common, tracing > Affects Versions: 3.0.0-alpha3 > Reporter: Weisen Han > Assignee: Weisen Han > Priority: Trivial > Attachments: HADOOP-14533-001.patch, HADOOP-14533-002.patch > > > {code} > @Override > public int run(String argv[]) throws Exception { > LinkedList<String> args = new LinkedList<String>(); > …… > if (args.size() < 0) { > System.err.println("You must specify an operation."); > return 1; > } > …… > } > {code} > From the code above, the {{args}} is a linklist obejct, so it cannot be less > than zero.meaning that code below is wrong > {code} > if (args.size() < 0) { > System.err.println("You must specify an operation."); > return 1; > } > {code} -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org