[
https://issues.apache.org/jira/browse/HADOOP-16029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16738598#comment-16738598
]
Ayush Saxena commented on HADOOP-16029:
---------------------------------------
Thankx [~giovanni.fumarola] for reviewing
I have made changes to the indentation as suggested
For the GraphiteSink I have corrected the whole for block.Since if I keep it
same there is existing checkstyle Warning which pops up here to since I have
touched the line.
Can give a check [here in the trunk
checkstyle|https://builds.apache.org/job/hadoop-qbt-trunk-java8-linux-x86/1011/artifact/out/diff-checkstyle-root.txt]
result the whole file has checkstyle problem.
> Consecutive Append Should Reuse
> -------------------------------
>
> Key: HADOOP-16029
> URL: https://issues.apache.org/jira/browse/HADOOP-16029
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HADOOP-16029-01.patch, HADOOP-16029-02.patch,
> HADOOP-16029-03.patch, HADOOP-16029-04.patch
>
>
> Consecutive calls to StringBuffer/StringBuilder .append should be chained,
> reusing the target object. This can improve the performance by producing a
> smaller bytecode, reducing overhead and improving inlining.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
