sunchao commented on a change in pull request #2256:
URL: https://github.com/apache/hadoop/pull/2256#discussion_r479426043
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSZKFailoverController.java
##########
@@ -158,7 +158,7 @@ public static DFSZKFailoverController create(Configuration
conf) {
"You may run zkfc on the node other than namenode.";
throw new HadoopIllegalArgumentException(msg);
}
- NameNode.initializeGenericKeys(localNNConf, nsId, nnId);
Review comment:
Yes but as I said, the call in `NNHAServiceTarget` is on a copy:
```java
// Make a copy of the conf, and override configs based on the
// target node -- not the node we happen to be running on.
HdfsConfiguration targetConf = new HdfsConfiguration(conf);
NameNode.initializeGenericKeys(targetConf, nsId, nnId);
```
so the original `localNNConf` won't have those set. I'm not sure there will
be any side effect by doing this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
