mukund-thakur commented on pull request #2257:
URL: https://github.com/apache/hadoop/pull/2257#issuecomment-688823862


   > checkstyle complaining with fixable issues
   > 
   > ```
   > 
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Listing.java:370:
    Listing.FileStatusListingIterator filesItr = 
createFileStatusListingIterator(: Line is longer than 80 characters (found 81). 
[LineLength]
   > 
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:34:import
 java.util.Arrays;:8: Unused import - java.util.Arrays. [UnusedImports]
   > 
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:2672:
  private RemoteIterator<S3AFileStatus> innerListStatus(Path f) throws 
FileNotFoundException,: Line is longer than 80 characters (found 93). 
[LineLength]
   > 
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:2686:
    }:5: '}' at column 5 should be on the same line as the next part of a 
multi-block statement (one that directly contains multiple blocks: 
if/else-if/else, do/while or try/catch/finally). [RightCurly]
   > 
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/S3ATestUtils.java:45:import
 org.apache.hadoop.fs.s3a.impl.TestPartialDeleteFailures;:8: Unused import - 
org.apache.hadoop.fs.s3a.impl.TestPartialDeleteFailures. [UnusedImports]
   > 
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestS3Guard.java:138:
    S3AFileStatus[] result = S3AUtils.iteratorToStatuses(resultItr, new 
HashSet<>());: Line is longer than 80 characters (found 85). [LineLength]
   > 
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/s3guard/TestS3Guard.java:205:
    S3AFileStatus[] result = S3AUtils.iteratorToStatuses(resultItr, new 
HashSet<>());: Line is longer than 80 characters (found 85). [LineLength]
   > ```
   
   Yes I am going to fix the checkstyle. How is the rest of code? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org

Reply via email to