xicm commented on a change in pull request #3634: URL: https://github.com/apache/hadoop/pull/3634#discussion_r747147592
########## File path: hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Quota.java ########## @@ -50,7 +50,7 @@ public static Counts newInstance() { * The quota is violated if quota is set and usage > quota. */ public static boolean isViolated(final long quota, final long usage) { - return quota >= 0 && usage > quota; + return quota >= 0 && usage >= quota; Review comment: ok, I'm new to this, I'm not sure what to do next,update the JIRA and PR, then create another JIRA to add the UT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org