xinglin commented on code in PR #5809: URL: https://github.com/apache/hadoop/pull/5809#discussion_r1256899902
########## hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java: ########## @@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() { public List<FsVolumeImpl> getVolumeList() { return null; } + + @Override + public void setLastDirScannerFinishTime(long time) {} Review Comment: Is there a reason that in one test case, we throw an unsupported exception while in this test class, it is a no-op? can we make both behave the same way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org