on 3/22/02 9:46 PM, "Jeff Turner" <[EMAIL PROTECTED]> wrote:
> Hi Jon,
>
> Would you be happy (ie, would it build on your system) if we applied the
> patch with the following modifications?
>
> 1) Source ${basedir}/build.properties before
> ${user.home}/build.properties
>
> Many people have a ~/build.properties with default values, which only
> needs to be overridden by ./build.properties for unusual cases. Changing
> the order breaks these people's setups. So I'm proposing that the order
> be:
>
> <property file="${basedir}/build.properties" />
> <property file="${user.home}/beanutils.build.properties" />
> <property file="${user.home}/build.properties" />
> <property file="${basedir}/default.properties" />
-1. The order that I have it in is done on purpose and has worked well for a
long time for Scarab, Turbine, Lucene, etc. The point is that the
~/build.properties is like a globally defined set of props.
I don't see how changing the order would break people's setups.
> 2) Not delete build.properties.sample. Ie, defaults.properties will
> default the values to ${lib.repo}/.., but people without a jar
> repository can still 'cp build.properties.sample build.properties' and
> have things working.
-1
If anything you should do:
cp default.properties build.properties
> I quite like the defaults.properties idea. Keeps build.xml clean, and
> you don't lose your place in build.xml when looking up the value of a
> property.
The whole point is that you don't have to look at build.xml to change
properties. Much like you shouldn't have to look at a ./configure script.
> If we're all happy with this, the change should be done to all projects,
> not just beanutils (yes I volunteer).
I have already started doing that for all of the projects that Scarab has a
dependency on (which is quite a lot of projects at this point...31 .jar
files)...
./activation-1.0.1.jar
./commons-beanutils.jar
./commons-codec-1.0-dev.jar
./commons-collections.jar
./commons-digester-1.1.jar
./commons-email-0.1-dev.jar
./commons-http.jar
./commons-io.jar
./commons-lang-1.0-dev.jar
./commons-logging-20020321.jar
./commons-util-1.0-rc2-dev.jar
./dom4j-full-1.3.jar
./flux-3.0-dev.jar
./fulcrum-1.0.jar
./jakarta-regexp-1.3-dev.jar
./JavaGroups-2.0.jar
./jdbc2_0-stdext.jar
./junit-3.7.jar
./log4j-1.1.3.jar
./lucene-1.2-rc4.jar
./mail-1.2.jar
./mm.mysql-2.0.11-bin.jar
./postgresql-7.2.jar
./servlet-2.2-CVSHEAD-12-04-00.jar
./stratum-1.0-b2-dev.jar
./turbine-3.0-dev.jar
./velocity-1.3-rc1.jar
./village-1.5.2.jar
./xalan-2.1.0.jar
./xerces-1.4.4.jar
./xmlParserAPIs-2.0.0.jar
-jon
--
To unsubscribe, e-mail: <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
