Vinay,

This looks good.  We will be able to keep the way it is now for people 
that do not need callback and have the alternate impls for that that 
need callback enabled.

Keep up the good work!

I'm about to change references of "classOrInterfacesToExpose" to 
"interfacesToExpose" as that is what we support and the whole design 
idea behind AltRMI because of our creation of proxies.  I will commit 
the code and replicate it to EOB and Cornerstone, I hope there are not 
too many implications for your work in progress.....

Regards,

- Paul


>Paul,
>Skeleton work on Callback ....
>
>It doesnt actually do the callback(:))) 
>but just mocks the way we can acheive it.
>I have short-circuited the handling ,
>and thus the tests work fine tooo (can you check
>the performance drop),only difference being
>the way data is read from the server.
>
>Thoughts ???
>(Dont apply these to the CVS )
>
>So does the client side also does a publish(..)
>call to export its client objects to its 
>invocation handler .
>What is the deal??
>
>Regards,
>V i n a y
>
>
>===================================================
>Index: SocketClientTest.java
>===================================================================
>RCS file:
>/home/cvspublic/jakarta-commons-sandbox/altrmi/src/java/org/apache/commons/altrmi/test/SocketClientTest.java,v
>retrieving revision 1.10
>diff -r1.10 SocketClientTest.java
>13d12
>< import
>org.apache.commons.altrmi.client.AltrmiHostContext;
>15,18c14
>< import
>org.apache.commons.altrmi.common.AltrmiConnectionException;
>< import
>org.apache.commons.altrmi.client.impl.socket.SocketObjectStreamHostContext;
>< import
>org.apache.commons.altrmi.client.impl.socket.SocketCustomStreamHostContext;
>< import
>org.apache.commons.altrmi.client.impl.ServerClassAltrmiFactory;
>---
>
>>import
>>
>org.apache.commons.altrmi.client.AltrmiHostContext;
>20,21c16,21
>< 
>< import java.io.IOException;
>---
>
>>import
>>
>org.apache.commons.altrmi.client.impl.ServerClassAltrmiFactory;
>
>>import
>>
>org.apache.commons.altrmi.client.impl.socket.CallbackEnabledCustomSocketStreamHostContext;
>
>>import
>>
>org.apache.commons.altrmi.client.impl.socket.SocketCustomStreamHostContext;
>
>>import
>>
>org.apache.commons.altrmi.client.impl.socket.SocketObjectStreamHostContext;
>
>>import sun.security.krb5.internal.af;
>>import sun.security.krb5.internal.i;
>>
>57c57,60
><         } else {
>---
>
>>        } else
>>
>if(args[1].equals("CallbackEnabledCustomSocketStream")){
>
>>              System.out.println("Callback Enabled Custom
>>
>Socket Stream");
>
>>              arhc=  new
>>
>CallbackEnabledCustomSocketStreamHostContext("127.0.0.1",1235);
>
>>        }else {
>>
>======================================================
>Index: tests.xml
>===================================================================
>RCS file:
>/home/cvspublic/jakarta-commons-sandbox/altrmi/tests.xml,v
>retrieving revision 1.12
>diff -r1.12 tests.xml
>141a142,150
>
>>  <target name="socketc-callback-client"
>>
>description="Socket Client (CustomStream, client side
>classes)" depends="generate">
>
>>    <java
>>
>classname="org.apache.commons.altrmi.test.SocketClientTest"
>fork="true">
>
>>      <classpath refid="testA.classpath"/>
>>      <arg value="C"/>
>>      <arg
>>
>value="CallbackEnabledCustomSocketStream"/>
>
>>    </java>      
>>  </target>
>>
>>
>===================================================
>--- Paul Hammant <[EMAIL PROTECTED]> wrote:
>
>>Vinay,
>>
>>I've committed your changes,  In testing the
>>performance drop for 
>>'pipeda' was between 2 & 6%.  This is not bad. For
>>the direct types it 
>>would be a bit more.
>>The benefit would outweigh the performace drop of
>>course, but maybe we 
>>might revisit this in time...  This email is a place
>>marker for that.... :-)
>>
>>I've also formatted the source with JIndent, so
>>there may be whitespace 
>>changes versus your local copy...
>>
>>- Paul
>>
>>
>>>hammant     02/03/22 14:51:37
>>>
>>> Modified:   
>>>
>altrmi/src/java/org/apache/commons/altrmi/client/impl
>
>>>                       BaseServedObject.java
>>>             
>>>
>>altrmi/src/java/org/apache/commons/altrmi/generator
>>
>>>                       ProxyGeneratorImpl.java
>>>             
>>>
>>altrmi/src/java/org/apache/commons/altrmi/server
>>
>>>                       AltrmiPublisher.java
>>>             
>>>
>altrmi/src/java/org/apache/commons/altrmi/server/impl
>
>>>                       AbstractServer.java
>>>                      
>>>
>>DefaultMethodInvocationHandler.java
>>
>>>             
>>>
>altrmi/src/java/org/apache/commons/altrmi/server/impl/adapters
>
>>>                       PublicationAdapter.java
>>> 
>>>
>>
>>
>>--
>>To unsubscribe, e-mail:  
>><mailto:[EMAIL PROTECTED]>
>>For additional commands, e-mail:
>><mailto:[EMAIL PROTECTED]>
>>
>
>
>__________________________________________________
>Do You Yahoo!?
>Yahoo! Movies - coverage of the 74th Academy Awards®
>http://movies.yahoo.com/
>
>
>------------------------------------------------------------------------
>
>--
>To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
>For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>
>




--
To unsubscribe, e-mail:   <mailto:[EMAIL PROTECTED]>
For additional commands, e-mail: <mailto:[EMAIL PROTECTED]>

Reply via email to