Did anyone have any comments on this? Wouldn't this detangle the core and define taglib quite nicely?
-- knut > -----Original Message----- > From: Wannheden, Knut [mailto:[EMAIL PROTECTED]] > Sent: Donnerstag, 23. Januar 2003 12:00 > To: Jakarta-Commons-Dev (E-mail) > Subject: [jelly] [PATCH] StaticTagScript and define taglib > > > The protected method findDynamicTag() in > org.apache.commons.jelly.impl.StaticTagScript assumes that > any dynamically > registered TagLibrary (with the URI of this Tag) is an instance of a > DynamicTagLibrary. It could however be any kind of > TagLibrary. This patch > removes this unnecessary dependency. > > As a further step I think that all the > org.apache.commons.jelly.impl.Dynamic* classes (including > DynamicBeanTag, > DynamicDynaBeanTag, DynamicTag, and DynamicTagLibrary) can be > moved to the > define tag library, which was split off the core. There > aren't any classes > in core that depend on them (except the yet unpatched > StaticTagScript ;-)). > > Cheers, > > -- > knut > >