Robert, Thanks for your response. I've changed the copyright date to 2004 and changed the author to myself for the new classes.
As discussed elsewhere I agree with the decision to leave Bug 23815 but I think that Bug 28813 (getNestedProperty handles Maps with a "dot notation" but setNestedProperty and getPropertyDescriptor do not) should be fixed. This seems a straight bug to me - setNestedProperty and getPropertyDescriptor don't work properly. http://issues.apache.org/bugzilla/show_bug.cgi?id=28813 I've now attached revised patches for PropertyUtilsBean and the Test Case that fix just this issue - all I did was change the "while loop" logic in the setNestedProperty and getPropertyDescriptor methods to the same as that in getNestedProperty. What do you think? Niall ----- Original Message ----- From: "robert burrell donkin" <[EMAIL PROTECTED]> To: "Jakarta Commons Developers List" <[EMAIL PROTECTED]> Sent: Tuesday, July 13, 2004 10:20 PM Subject: Re: [beanutils] Summary of propsed/committed changes for Bugs > On 12 Jul 2004, at 01:37, Niall Pemberton wrote: > > > Robert, > > Niall > > > I thought I would just summarise what I've done on beanutils to date, > > so > > that its easier for you (or others to review) - theres basically four > > main > > pieces of work which I highlight in the "Summary" below, but I've also > > detailed all the bugs I changed under "Detail" below. > > good plan > > > SUMMARY > > ========= > > 1) Committed fixes for Bug 28684 to the "numeric" locale converters > > and > > added test cases. > > that's good work. for some reason, the commit email didn't seem to make > it through so i took at the diffs using CVS. looks good but there are a > couple of small improvements you could make to the new files you added: > firstly, it's nice for the copyright to indicate 2004 (i know that the > copyright dates are inaccurate in most of the files); secondly, you're > the original author so either add your name or put something like > jakarta commons team (as you wish) - there are too many files with my > name at the top already, it's only fair that you start to share the > blame ;) > > > 2) Added patch for review to Bug 29772 to fix issues in > > DateLocaleConverter and addtional tests > > took a look but found i couldn't do anything better than you (so > committed the changes you proposed). > > > 3) Added patch for review to Bug 23815 to fix issues in > > PropertyUtilsBean - however these changes are also incorporated in the > > patch > > attached to Bug 28813 below and its that patch that I hope to committ. > > 4) Added patch for review to Bug 28813 to fix issues in > > PropertyUtilsBean - working on addtional tests which I will attach to > > the > > bug for review when I've completed them. > > i'd prefer for these to be addressed more fuller in a subsequent > release. i think probably craig right and we should discuss the right > designs to take beanutils forwards. it'd be good if you could hang > around for that... > > - robert > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
