The following issue has been updated: Updater: Ben Anderson (mailto:[EMAIL PROTECTED]) Date: Wed, 29 Sep 2004 4:05 PM Comment: This is the same patch as before, but it actually works. I wrote more extensive testing. The fix over this one as to the previos patch is that I was creating an anonymous inner class, which extended Object. Now I copied the LoopTagStatus interface from standard taglibs, so that the anonymous inner class implements that. That seems to have fixed the problem. Also, I found another existing bug. The "end" attribute in supposed to be inclusive, but it was behaving as exclusive. Changes: Attachment changed to forEach2.patch --------------------------------------------------------------------- For a full history of the issue, see:
http://issues.apache.org/jira/browse/JELLY-150?page=history --------------------------------------------------------------------- View the issue: http://issues.apache.org/jira/browse/JELLY-150 Here is an overview of the issue: --------------------------------------------------------------------- Key: JELLY-150 Summary: j:forEach tag not properly using varStatus attribute Type: Bug Status: Unassigned Priority: Major Project: jelly Components: core / taglib.core Versions: 1.0-beta-4 1.0 1.1-beta-1 jface-1.0-beta-1 jface-1.0 swt-1.0 1.0-beta-5 Assignee: Reporter: Ben Anderson Created: Fri, 24 Sep 2004 4:57 AM Updated: Wed, 29 Sep 2004 4:05 PM Environment: win2k / cygwin Description: According to the jstl specification 1.1, the varStatus attribute of the forEach tag should create a variable with type javax.servlet.jsp.jstl.core.LoopTagStatus. Currently a variable is set with type Integer which contains the index of the current iteration. I created a test case (I don't think any existed for forEach) that demonstrates this. I also began making the fix, but it doesn't fully work. I am submitting my patch along with the test cases. The comments I placed in the code should be enough to tip someone off as to why it's not working (I hope). I am relatively new to jelly (been using the standard taglibs for awhile) and have never opened the source before. I am willing to complete the patch, but will probably need some guidance because I messed with it for awhile before determing I couldn't complete without some help. Thanks! :-) --------------------------------------------------------------------- JIRA INFORMATION: This message is automatically generated by JIRA. If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa If you want more information on JIRA, or have a bug to report see: http://www.atlassian.com/software/jira --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]