Author: sandymac Date: Thu Mar 30 22:28:32 2006 New Revision: 390342 URL: http://svn.apache.org/viewcvs?rev=390342&view=rev Log: Fix: optimization where EvictInvalidFrequencyMillis is less than EvictIdleMillis could be optimized out had the comparison backwards.
Modified: jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPoolFactory.java Modified: jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPoolFactory.java URL: http://svn.apache.org/viewcvs/jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPoolFactory.java?rev=390342&r1=390341&r2=390342&view=diff ============================================================================== --- jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPoolFactory.java (original) +++ jakarta/commons/proper/pool/trunk/src/java/org/apache/commons/pool/composite/CompositeObjectPoolFactory.java Thu Mar 30 22:28:32 2006 @@ -315,7 +315,7 @@ if (!(lender instanceof NullLender)) { // If the evictIdleMillis were less than evictInvalidFrequencyMillis // then the InvalidEvictorLender would never run. - if (config.evictInvalidFrequencyMillis > 0 && config.evictIdleMillis > config.evictInvalidFrequencyMillis) { + if (config.evictInvalidFrequencyMillis > 0 && config.evictIdleMillis < config.evictInvalidFrequencyMillis) { lender = new InvalidEvictorLender(lender); ((InvalidEvictorLender)lender).setValidationFrequencyMillis(config.evictInvalidFrequencyMillis); } --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]