Ganbold wrote:
Roman,

Roman Kurakin wrote:
Ganbold wrote:
Roman Kurakin wrote:
rik         2008-09-27 14:30:34 UTC

  FreeBSD src repository

  Modified files:
    sbin/ipfw            ipfw2.c   Log:
  SVN rev 183407 on 2008-09-27 14:30:34Z by rik
Add keyword all in addtion to the table number for the 'list' and the
  'flush' actions on tables.  Part of PR: 127058.

Thanks a lot, Roman.
With the last one just committed the all parts of PR should now be done.
So please test all the parts (also 'table all flush' as a bonus) and I will close
the PR.
...
cc -O2 -pipe -fstack-protector -Wno-pointer-sign -c /usr/src/sbin/ipfw/ipfw2.c
/usr/src/sbin/ipfw/ipfw2.c: In function 'table_handler':
/usr/src/sbin/ipfw/ipfw2.c:5969: error: too few arguments to function 'table_list'
*** Error code 1

Stop in /usr/src/sbin/ipfw.
Fixed, thanks. Hate manual merge via cut & paste. Pointy hat to me.

rik


You forgot to add is_all as argument to table_list():
...
   } else if (_substrcmp(*av, "list") == 0) {
       a = is_all ? tables_max : (ent.tbl + 1);
       do {
         table_list(ent, is_all);
                               ^^^^
       } while (++ent.tbl < a);
   } else
...

Corrected version works, lists all tables' IP and flushes all.
Will check man page shortly.

thanks,

Ganbold


rik
Ganbold

    PR:             127058 (based on)
  MFC after:      1 month
    Revision  Changes    Path
  1.129     +29 -8     src/sbin/ipfw/ipfw2.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"





_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"






_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "[EMAIL PROTECTED]"

Reply via email to