On Thu, 2011-06-16 at 16:47:33 +0000, Alexey Dokuchaev wrote: > On Thu, Jun 16, 2011 at 08:42:28AM +0000, Wen Heping wrote: > > wen 2011-06-16 08:42:28 UTC > > > > Modified files: > > sysutils/tmux Makefile > > Log: > > - Fix build when CFLAGS is set in /etc/make.conf > > Hmm, default CPPFLAGS is empty. Judging just from the diff, instead of > introducing EXTRA_CPPFLAGS, setting CPPFLAGS instead of CFLAGS (which is > bogus in the first place: -I is preprocessor flag) should be enough (no > MAKE_ENV adjustment and extra REINPLACE_CMD hack would be required in this > case as well). I am missing something obvious here?
Because of the way upstream Makefile handles CPPFLAGS, it is not so straightforward. This was discussed on freebsd-ports: http://lists.freebsd.org/pipermail/freebsd-ports/2011-June/068218.html http://lists.freebsd.org/pipermail/freebsd-ports/2011-May/067930.html -- Sahil Tandon <sa...@freebsd.org> _______________________________________________ cvs-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "cvs-all-unsubscr...@freebsd.org"
