So, I see that you have taken care of the markVisited() bug.  There's
that one, the proxy port one, and the "d.sh" postinstall one, all of
which still exist in the wild in current setup.exe no?

I'm posting the patch for the manifest.  If there are no objections I'd
like to commit this and see about rolling a test release soon.  How does
that sound Max?

2005-05-03  Brian Dessent  <[EMAIL PROTECTED]>

        * res.rc: (CREATEPROCESS_MANIFEST_RESOURCE_ID): Define so that
        manifest is included in the binary.  This causes the common
        controls to appear more modern on recent versions of Windows.
        * setup.exe.manifest: New file.
Index: res.rc
===================================================================
RCS file: /cvs/cygwin-apps/setup/res.rc,v
retrieving revision 2.58
diff -u -r2.58 res.rc
--- res.rc      20 Nov 2004 17:25:29 -0000      2.58
+++ res.rc      3 May 2005 22:51:40 -0000
@@ -497,6 +497,8 @@
     IDS_UNCAUGHT_EXCEPTION_WITH_ERRNO  "Fatal Error: Uncaught 
Exception\nThread: %s\nType: %s\nMessage: %s\nAppErrNo: %d"
 END
 
+CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST "setup.exe.manifest"
+
 #endif    // English (U.S.) resources
 /////////////////////////////////////////////////////////////////////////////
 
--- /dev/null   2005-05-03 15:56:41.072375000 -0700
+++ setup.exe.manifest  2005-05-03 15:23:04.619250000 -0700
@@ -0,0 +1,22 @@
+<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
+<assembly xmlns="urn:schemas-microsoft-com:asm.v1" manifestVersion="1.0">
+<assemblyIdentity
+    version="1.0.0.0"
+    processorArchitecture="X86"
+    name="RedHat.Cygwin.Setup"
+    type="win32"
+/>
+<description>Cygwin installation tool</description>
+<dependency>
+    <dependentAssembly>
+        <assemblyIdentity
+            type="win32"
+            name="Microsoft.Windows.Common-Controls"
+            version="6.0.0.0"
+            processorArchitecture="X86"
+            publicKeyToken="6595b64144ccf1df"
+            language="*"
+        />
+    </dependentAssembly>
+</dependency>
+</assembly>

Reply via email to