On Sat, 28 Jan 2006, Brian Dessent wrote:

> Lapo Luchini wrote:
>
> > http://cyberx.lapo.it/cygwin/bsdiff/
> > http://cyberx.lapo.it/cygwin/bsdiff/bsdiff-4.3-1-src.tar.bz2
> > http://cyberx.lapo.it/cygwin/bsdiff/bsdiff-4.3-1.tar.bz2
>
> bsdiff-4.3.README contains <VER> and <REL> from the template.  It is my
> understanding that these should be substituted for the actual values in
> the README.

Your understanding is correct.

> Also, the binary package contains the empty directory
> "/usr/share/doc/bsdiff-4.3/".  It seems pointless to create this if
> there is no documentation to go there, and the user might think
> something was missing.

This is actually g-b-s creating the directory unconditionally.  I'm
testing a rework of the logging code now, and will try to insert a check
for documentation after that.  Not a showstopper, IMO.

> Otherwise everything looks fine.  Building from the source package and a
> quick test of the binary both seemed ok.  This looks like a useful app,
> so I guess +1 from me.

        Igor
-- 
                                http://cs.nyu.edu/~pechtcha/
      |\      _,,,---,,_            [EMAIL PROTECTED] | [EMAIL PROTECTED]
ZZZzz /,`.-'`'    -.  ;-;;,_            Igor Peshansky, Ph.D. (name changed!)
     |,4-  ) )-,_. ,\ (  `'-'           old name: Igor Pechtchanski
    '---''(_/--'  `-'\_) fL     a.k.a JaguaR-R-R-r-r-r-.-.-.  Meow!

"Las! je suis sot... -Mais non, tu ne l'es pas, puisque tu t'en rends compte."
"But no -- you are no fool; you call yourself a fool, there's proof enough in
that!" -- Rostand, "Cyrano de Bergerac"

Reply via email to