On 11/19/2010 11:25 AM, Sergei Shtylyov wrote: [...] >> + ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel"); > > Why not just: > > int ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel"); > > Also, and empty line after declaration wouldn't hurt. > [...] >> + return gpio_set_value(gpio, cs ? 1 : 0); > > Why not do it right with gpio_direction_output() call?
Sure. I might as well change to use gpio_request_one() while I'm at it. If I get enough comments to warrant another revision of this series, I will put in this change at the time. Otherwise, I'd rather roll this in with other patches on my pending list. Is that ok? Thanks for taking a look, Sergei. Regards - Cyril. _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source
