On Wednesday 10 October 2012 12:32:54 Constantine Shulyupin wrote: > From: Constantine Shulyupin <co...@makelinux.com> > > Function skel_open increments usage count for the device with kref_get and > the usage count should be decremented on the function failure. > > Some last changes in function skel_open and finally commit > 52a7499 Revert "USB: usb-skeleton.c: fix open/disconnect race" > introduced a bug in function skel_open, which this patch fixes. > > -- > Changelog: > -- Fixed accordinly feedback of Oliver Neukum oneu...@suse.de: also need to > drop the lock.
Well, touching file->private_data is not nice. It is correct, but really dirty. The skeleton driver should be nice. Could you introduce a second label for goto at the right place? Regards Oliver _______________________________________________ Davinci-linux-open-source mailing list Davinci-linux-open-source@linux.davincidsp.com http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source