Your message dated Sat, 31 Jul 2010 22:17:29 +0000
with message-id <[email protected]>
and subject line Bug#585969: fixed in lxtask 0.1.3-2
has caused the Debian Bug report #585969,
regarding lxtask: FTBFS on kfreebsd-*: expected identifier or '(' before
numeric constant
to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact [email protected]
immediately.)
--
585969: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=585969
Debian Bug Tracking System
Contact [email protected] with problems
--- Begin Message ---
Source: lxtask
Version: 0.1.3-1
Severity: important
Tags: patch
User: [email protected]
Usertags: kfreebsd
Hi,
your package FTBFS on GNU/kFreeBSD:
| make[3]: Entering directory
`/build/buildd-lxtask_0.1.3-1-kfreebsd-amd64-9XdDVu/lxtask-0.1.3/src'
| gcc -DHAVE_CONFIG_H -I. -I.. -I../include
-DG_LOG_DOMAIN=\"xfce4-taskmanager\" -DPACKAGE_LOCALE_DIR=\"/usr/share/locale\"
-pthread -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include
-I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0
-I/usr/include/gio-unix-2.0/ -I/usr/include/pixman-1 -I/usr/include/freetype2
-I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include
-g -O2 -c -o lxtask-main.o `test -f 'main.c' || echo './'`main.c
| main.c:54: error: expected identifier or '(' before numeric constant
| main.c: In function 'main':
| main.c:68: error: lvalue required as left operand of assignment
| make[3]: *** [lxtask-main.o] Error 1
The issue being PAGE_SIZE, which is defined already.
I'm attaching the patch I came up with, which seems to solve this FTBFS.
Thanks for considering.
Mraw,
KiBi.
diff -Nru lxtask-0.1.3/debian/changelog lxtask-0.1.3/debian/changelog
--- lxtask-0.1.3/debian/changelog 2010-06-11 21:36:12.000000000 +0200
+++ lxtask-0.1.3/debian/changelog 2010-06-15 11:09:15.000000000 +0200
@@ -1,3 +1,10 @@
+lxtask (0.1.3-2) unstable; urgency=low
+
+ * Replace PAGE_SIZE with page_size everywhere, since the former might
+ be defined through system-wide headers (e.g. on GNU/kFreeBSD).
+
+ -- Cyril Brulebois <[email protected]> Tue, 15 Jun 2010 11:08:17 +0200
+
lxtask (0.1.3-1) unstable; urgency=low
[ Julien Lavergne ]
diff -Nru lxtask-0.1.3/debian/patches/debian-changes-0.1.3-2 lxtask-0.1.3/debian/patches/debian-changes-0.1.3-2
--- lxtask-0.1.3/debian/patches/debian-changes-0.1.3-2 1970-01-01 01:00:00.000000000 +0100
+++ lxtask-0.1.3/debian/patches/debian-changes-0.1.3-2 2010-06-15 11:09:21.000000000 +0200
@@ -0,0 +1,69 @@
+Description: Upstream changes introduced in version 0.1.3-2
+ This patch has been created by dpkg-source during the package build.
+ Here's the last changelog entry, hopefully it gives details on why
+ those changes were made:
+ .
+ lxtask (0.1.3-2) unstable; urgency=low
+ .
+ * Replace PAGE_SIZE with page_size everywhere, since the former might
+ be defined through system-wide headers (e.g. on GNU/kFreeBSD).
+ .
+ The person named in the Author field signed this changelog entry.
+Author: Cyril Brulebois <[email protected]>
+
+---
+The information above should follow the Patch Tagging Guidelines, please
+checkout http://dep.debian.net/deps/dep3/ to learn about the format. Here
+are templates for supplementary fields that you might want to add:
+
+Origin: <vendor|upstream|other>, <url of original patch>
+Bug: <url in upstream bugtracker>
+Bug-Debian: http://bugs.debian.org/<bugnumber>
+Bug-Ubuntu: https://launchpad.net/bugs/<bugnumber>
+Forwarded: <no|not-needed|url proving that it has been forwarded>
+Reviewed-By: <name and email of someone who approved the patch>
+Last-Update: <YYYY-MM-DD>
+
+--- lxtask-0.1.3.orig/src/main.c
++++ lxtask-0.1.3/src/main.c
+@@ -51,7 +51,7 @@ guint win_height;
+ guint refresh_interval;
+ guint rID;
+
+-int PAGE_SIZE;
++int page_size;
+
+ int main (int argc, char *argv[])
+ {
+@@ -65,7 +65,7 @@ int main (int argc, char *argv[])
+ gtk_set_locale ();
+ gtk_init (&argc, &argv);
+
+- PAGE_SIZE=sysconf(_SC_PAGESIZE)>>10;
++ page_size=sysconf(_SC_PAGESIZE)>>10;
+ own_uid = getuid();
+
+ config_file = g_build_filename(g_get_user_config_dir(), "lxtask.conf", NULL);
+--- lxtask-0.1.3.orig/src/types.h
++++ lxtask-0.1.3/src/types.h
+@@ -78,6 +78,6 @@ extern guint win_height;
+ const gchar *custom_signal_0;
+ const gchar *custom_signal_1;
+
+-extern int PAGE_SIZE;
++extern int page_size;
+
+ #endif
+--- lxtask-0.1.3.orig/src/xfce-taskmanager-linux.c
++++ lxtask-0.1.3/src/xfce-taskmanager-linux.c
+@@ -46,8 +46,8 @@ void get_task_details(gint pid,struct ta
+ sscanf(line,"%d %d",&task->size,&task->rss);
+ close(fd);
+ if(!task->size) return;
+- task->size*=PAGE_SIZE;
+- task->rss*=PAGE_SIZE;
++ task->size*=page_size;
++ task->rss*=page_size;
+
+ sprintf(line,"/proc/%d/stat",pid);
+ fd=open(line,O_RDONLY);
diff -Nru lxtask-0.1.3/debian/patches/series lxtask-0.1.3/debian/patches/series
--- lxtask-0.1.3/debian/patches/series 1970-01-01 01:00:00.000000000 +0100
+++ lxtask-0.1.3/debian/patches/series 2010-06-15 11:09:21.000000000 +0200
@@ -0,0 +1 @@
+debian-changes-0.1.3-2
--- End Message ---
--- Begin Message ---
Source: lxtask
Source-Version: 0.1.3-2
We believe that the bug you reported is fixed in the latest version of
lxtask, which is due to be installed in the Debian FTP archive:
lxtask_0.1.3-2.debian.tar.gz
to main/l/lxtask/lxtask_0.1.3-2.debian.tar.gz
lxtask_0.1.3-2.dsc
to main/l/lxtask/lxtask_0.1.3-2.dsc
lxtask_0.1.3-2_amd64.deb
to main/l/lxtask/lxtask_0.1.3-2_amd64.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to [email protected],
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Andrew Lee (李健秋) <[email protected]> (supplier of updated lxtask package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing [email protected])
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Sat, 31 Jul 2010 17:15:40 -0400
Source: lxtask
Binary: lxtask
Architecture: source amd64
Version: 0.1.3-2
Distribution: unstable
Urgency: low
Maintainer: Debian LXDE Packaging Team
<[email protected]>
Changed-By: Andrew Lee (李健秋) <[email protected]>
Description:
lxtask - process manager for Lightweight X11 Desktop Environment
Closes: 585969
Changes:
lxtask (0.1.3-2) unstable; urgency=low
.
[ Cyril Brulebois ]
* Replace PAGE_SIZE with page_size everywhere, since the former might
be defined through system-wide headers (e.g. on GNU/kFreeBSD).
(Closes:585969)
.
[ Andrew Lee (李健秋) ]
* Build-depends on debhelper >= 7.0.50~
* Bumped Standard-version to 3.9.1
Checksums-Sha1:
1974289915fc0c70a3cb154222e62382d3d8f6d1 1330 lxtask_0.1.3-2.dsc
6e4bb56345ead435daffbef70297042b236eea97 3627 lxtask_0.1.3-2.debian.tar.gz
b24a527dcdea2e5070fc9096184cb550e72c2bc6 57268 lxtask_0.1.3-2_amd64.deb
Checksums-Sha256:
8ce603cb58403718d631421e0d54f8fbacb99d03b854adcd0ecce42daa5512ee 1330
lxtask_0.1.3-2.dsc
644e36f2f9981217e30ac8b7d38e19643c6dc63a977c94392cf5e5c6dd96b27a 3627
lxtask_0.1.3-2.debian.tar.gz
357f26992e947ec7ee115502ff0d065b311fa8504bb6eccc7b26c3066c4c4ced 57268
lxtask_0.1.3-2_amd64.deb
Files:
c5f3322617c5330d883ba843be1a1ac6 1330 x11 extra lxtask_0.1.3-2.dsc
604d585c80386ed4b4c05a1a5f5ef714 3627 x11 extra lxtask_0.1.3-2.debian.tar.gz
0fc68269de939f5e897a4c4a5e30432e 57268 x11 extra lxtask_0.1.3-2_amd64.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAkxUnskACgkQnQYz4bYlCYVZqwCgxdKWHBgjAVoRSlLHYaJbI7Gj
+BsAoMZu6nCjrBzH467y/JRlv9OY9Siz
=JLLe
-----END PGP SIGNATURE-----
--- End Message ---
