Your message dated Wed, 11 Dec 2019 13:49:10 +0000 with message-id <[email protected]> and subject line Bug#934140: fixed in brightd 0.4.1-3 has caused the Debian Bug report #934140, regarding brightd does not fade to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact [email protected] immediately.) -- 934140: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=934140 Debian Bug Tracking System Contact [email protected] with problems
--- Begin Message ---Package: brightd Version: 0.4.1-2 Severity: grave Justification: renders package unusable Dear Maintainer, brightd does not fade because it wrongly thinks laptop is always on AC. The problem is in the patch 0002-Don-t-use-deprecated-proc-acpi-for-AC-detection.patch | FILE *ac = fopen("/sys/class/power_supply/AC/online", "r"); | ... | ac_state = fgetc(ac); | fclose(ac); | return ac_state; In the kernel from debian buster the file opened contains '0' or '1', the patch does not parse the character '0' but simple returns the character casted to an int. Which means the function isOnAC always returns true, which means brightd currently does nothing, it never fades. Output of brightd when on battery (or on AC, doesn't matter) |brightd -w 5 -v |Maximum brightness is 4437 |Opened X11 Display from ENV{DISPLAY} |Opened a connection |Would fade, but on AC |Would fade, but on AC |Would fade, but on AC | ... best regards, gebi -- System Information: Debian Release: 10.0 APT prefers stable APT policy: (500, 'stable') Architecture: amd64 (x86_64) Foreign Architectures: i386 Kernel: Linux 4.19.0-5-amd64 (SMP w/4 CPU cores) Kernel taint flags: TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8), LANGUAGE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Init: systemd (via /run/systemd/system) Versions of packages brightd depends on: ii libc6 2.28-10 ii libx11-6 2:1.6.7-1 ii libxss1 1:1.2.3-1 brightd recommends no packages. brightd suggests no packages. -- no debconf information
--- End Message ---
--- Begin Message ---Source: brightd Source-Version: 0.4.1-3 We believe that the bug you reported is fixed in the latest version of brightd, which is due to be installed in the Debian FTP archive. A summary of the changes between this version and the previous one is attached. Thank you for reporting the bug, which will now be closed. If you have further comments please address them to [email protected], and the maintainer will reopen the bug report if appropriate. Debian distribution maintenance software pp. Andrej Shadura <[email protected]> (supplier of updated brightd package) (This message was generated automatically at their request; if you believe that there is a problem with it please contact the archive administrators by mailing [email protected]) -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 Format: 1.8 Date: Wed, 11 Dec 2019 14:12:49 +0100 Source: brightd Architecture: source Version: 0.4.1-3 Distribution: unstable Urgency: medium Maintainer: Andrej Shadura <[email protected]> Changed-By: Andrej Shadura <[email protected]> Closes: 923266 934140 Changes: brightd (0.4.1-3) unstable; urgency=medium . [ Andrej Shadura ] * Actually compare the value read out of /sys/class/power_supply/AC/online with '0' (Closes: #934140). * Use debhelper-compat instead of debian/compat. * d/control: Set Vcs-* to salsa.debian.org. * Use secure URI in debian/watch. * Use secure URI in Homepage field. * Bump debhelper from old 9 to 12. * Provide machine-readable debian/copyright. * Machine-readable debian/copyright . [ Helmut Grohne ] * Fix FTCBFS (Closes: #923266): + cross.patch: Make compiler and install substitutable. + Let dh_auto_build pass a cross compiler to make. + Pass a non-stripping install to make install. Checksums-Sha1: e1d87208563715ffa5c4f71b68e4850d72ec23c6 1640 brightd_0.4.1-3.dsc 96054a9596f6a8c3fb384fb7f7187e33d41dd685 5404 brightd_0.4.1-3.debian.tar.xz Checksums-Sha256: 38ed2e5b67b9d5e1b8e9751a3840ced2986afdf813c9bd7a23616fd8af9b3eee 1640 brightd_0.4.1-3.dsc 392f276c593b7ef2fcae71214a66afdc202e6c57c8f16647d3cb82d6740f88f2 5404 brightd_0.4.1-3.debian.tar.xz Files: abab89dfc693e89f43a94b60000f49fd 1640 utils optional brightd_0.4.1-3.dsc f683f7ff6f4e0568137e8bbb3b091267 5404 utils optional brightd_0.4.1-3.debian.tar.xz -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEeuS9ZL8A0js0NGiOXkCM2RzYOdIFAl3w64wACgkQXkCM2RzY OdJdCAf+OzfxtUDEo5TLikaehIFOoj9cNmxGG9oLTHrP+BzSMhirzoxd4+xFFvfl 5UY5wxsu9LHufA36cK5QwI2UcnqlYLrURPDuJo6GFVFwFefchJa/gMMkzk7w+OFi Jt2XlgkKwfRWRujI8REhc+EZqWqswpH/Wl8gm86EwI95ktbnguvD+QYYStXwmUGb SGl7SJDL3uh3Yf0+YkHN/91BEIrvRXdSgIeO+HplqqEUdiEKcB8NjwKfNA2qC9lk L2fauoDTv8XI4hE/we8JbwyAp5Br+uCzGdF3jdOOV63dw/dQFTPmgAWw5dM3Kh0/ OTzvUT2N6WG6FnKS1fwqRk6CoOn/ow== =4xp4 -----END PGP SIGNATURE-----
--- End Message ---
