Your message dated Thu, 16 Aug 2012 13:19:46 +0100 with message-id <c166d9ab59bac14b50df1e6e88563...@mail.adsl.funky-badger.org> and subject line Re: Bug#685019: unblock: denemo/0.9.2-3 has caused the Debian Bug report #685019, regarding unblock: denemo/0.9.2-3 to be marked as done.
This means that you claim that the problem has been dealt with. If this is not the case it is now your responsibility to reopen the Bug report if necessary, and/or fix the problem forthwith. (NB: If you are a system administrator and have no idea what this message is talking about, this may indicate a serious mail system misconfiguration somewhere. Please contact ow...@bugs.debian.org immediately.) -- 685019: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=685019 Debian Bug Tracking System Contact ow...@bugs.debian.org with problems
--- Begin Message ---Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock Please unblock package denemo The last changes are based in the feedback that I got from: #684063 unblock: denemo/0.9.2-2 denemo/0.9.2-3 fixes: #665520 Including individual glib headers no longer supported #683563 Enable hardened build flags (Current version in testing: 0.9.2-1) denemo (0.9.2-3) unstable; urgency=low * Set the environment variables listed by dpkg-buildflags using a less intrusive approach: - debian/rules override_dh_auto_configure added to set the environment variables listed by dpkg-buildflags. - debian/compat changed from 9 to 7 - debian/control debhelper build dependency version reverted from 9 to 7.0.50~ denemo (0.9.2-2) unstable; urgency=low * glib-single-include.diff Patch added in order to include glib.h instead of individual header. Thanks to Michael Biebl for his help to fix this bug (closes: 665520). * debian/control - New maintainer address. Thanks to Jan Hauke Rahm for his sponsorships. - Standards Version updated to 3.9.3: No changes required. * Denemo now uses security hardening build flags (closes: 683563) - debian/compat, and debian/control build dependency on debhelper, raised to 9 in order to set environment variables listed by dpkg-buildflags by default. - format_error_strings.diff patch added to format error strings safely. Debdiff (against denemo/0.9.2-1 which is in testing) attached. unblock denemo/0.9.2-3 -- System Information: Debian Release: wheezy/sid Architecture: amd64 (x86_64) Kernel: Linux 3.2.0-3-amd64 (SMP w/4 CPU cores) Locale: LANG=es_GT.utf8, LC_CTYPE=es_GT.utf8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dashdiff -Nru denemo-0.9.2/debian/changelog denemo-0.9.2/debian/changelog --- denemo-0.9.2/debian/changelog 2011-10-04 16:35:55.000000000 -0600 +++ denemo-0.9.2/debian/changelog 2012-08-14 07:44:27.000000000 -0600 @@ -1,3 +1,31 @@ +denemo (0.9.2-3) unstable; urgency=low + + * Set the environment variables listed by dpkg-buildflags using + a less intrusive approach: + - debian/rules override_dh_auto_configure added to set the + environment variables listed by dpkg-buildflags. + - debian/compat changed from 9 to 7 + - debian/control debhelper build dependency version reverted + from 9 to 7.0.50~ + + -- Josue Abarca <jmasli...@debian.org> Tue, 13 Aug 2012 17:08:04 -0600 + +denemo (0.9.2-2) unstable; urgency=low + + * glib-single-include.diff Patch added in order to include glib.h + instead of individual header. Thanks to Michael Biebl for his help to + fix this bug (closes: 665520). + * debian/control + - New maintainer address. Thanks to Jan Hauke Rahm for his sponsorships. + - Standards Version updated to 3.9.3: No changes required. + * Denemo now uses security hardening build flags (closes: 683563) + - debian/compat, and debian/control build dependency on debhelper, + raised to 9 in order to set environment variables listed by + dpkg-buildflags by default. + - format_error_strings.diff patch added to format error strings safely. + + -- Josue Abarca <jmasli...@debian.org> Fri, 27 Jul 2012 23:37:51 -0600 + denemo (0.9.2-1) unstable; urgency=low * New upstream release diff -Nru denemo-0.9.2/debian/control denemo-0.9.2/debian/control --- denemo-0.9.2/debian/control 2011-10-04 16:35:55.000000000 -0600 +++ denemo-0.9.2/debian/control 2012-08-14 07:44:27.000000000 -0600 @@ -1,7 +1,7 @@ Source: denemo Section: sound Priority: optional -Maintainer: Josue Abarca <jmasli...@debian.org.gt> +Maintainer: Josue Abarca <jmasli...@debian.org> DM-Upload-Allowed: yes Build-Depends: debhelper (>= 7.0.50~), guile-1.8-dev, libaubio-dev, portaudio19-dev, libfftw3-dev, libgtk2.0-dev, @@ -9,7 +9,7 @@ libgtksourceview2.0-dev, libfluidsynth-dev, autoconf, automake1.11, libsmf-dev (>= 1.3), autopoint, librsvg2-dev, dh-autoreconf Build-Conflicts: autoconf2.13, automake1.4 -Standards-Version: 3.9.2 +Standards-Version: 3.9.3 Vcs-Git: git://anonscm.debian.org/collab-maint/denemo.git Vcs-Browser: http://anonscm.debian.org/gitweb/?p=collab-maint/denemo.git Homepage: http://www.denemo.org diff -Nru denemo-0.9.2/debian/patches/format_error_strings.diff denemo-0.9.2/debian/patches/format_error_strings.diff --- denemo-0.9.2/debian/patches/format_error_strings.diff 1969-12-31 18:00:00.000000000 -0600 +++ denemo-0.9.2/debian/patches/format_error_strings.diff 2012-08-14 07:44:27.000000000 -0600 @@ -0,0 +1,26 @@ +Description: This patch adds string literals + to format error strings in the g_print function. This is required by + -Werror=format-security to avoid format string attacks. This pacth + was backported in order to be able to use security hardening build + flags via dpkg-buildflags. + +Origin: upstream, http://git.savannah.gnu.org/gitweb/?p=denemo.git;a=commitdiff;h=e17c5abd +Author: Jeremiah Benham <jjben...@chicagoguitar.com> +Bug-Debian: http://bugs.debian.org/683563 +Last-Update: 2012-08-02 + +--- a/src/print.c ++++ b/src/print.c +@@ -1210,10 +1210,10 @@ + + gchar *mt = g_strdup_printf("%u", mtime); + if(!gdk_pixbuf_save (pbN, thumbpathN, "png"/*type*/, &err, "tEXt::Thumb::URI", uri, "tEXt::Thumb::MTime", mt , NULL)) +- g_print(err->message); ++ g_print("%s",err->message); + err = NULL; + if(!gdk_pixbuf_save (pbL, thumbpathL, "png"/*type*/, &err, "tEXt::Thumb::URI", uri, "tEXt::Thumb::MTime", mt , NULL)) +- g_print(err->message); ++ g_print("%s",err->message); + + //FIXME do the pbN L need freeing??? + g_free(uri); diff -Nru denemo-0.9.2/debian/patches/glib-single-include.diff denemo-0.9.2/debian/patches/glib-single-include.diff --- denemo-0.9.2/debian/patches/glib-single-include.diff 1969-12-31 18:00:00.000000000 -0600 +++ denemo-0.9.2/debian/patches/glib-single-include.diff 2012-08-14 07:44:27.000000000 -0600 @@ -0,0 +1,21 @@ +Description: Including invidiual glib headers + has been deprecated for several years. Starting with glib 2.32 it is + now mandatory to include glib.h instead of individual headers, or the + compiler will generate an error. + +Origin: upstream, http://git.savannah.gnu.org/gitweb/?p=denemo.git;a=commitdiff;h=0d189fa4 +Author: Adam Sampson +Bug-Debian: http://bugs.debian.org/665520 +Last-Update: 2012-06-26 + +--- a/src/pitchrecog.c ++++ b/src/pitchrecog.c +@@ -28,7 +28,7 @@ + #include <math.h> + #include <aubio/aubio.h> + #include <audio.h> +-#include <glib/gmessages.h> ++#include <glib.h> + + #ifdef HAVE_C99_VARARGS_MACROS + #define debug(...) if (verbose) fprintf (stderr, __VA_ARGS__) diff -Nru denemo-0.9.2/debian/patches/series denemo-0.9.2/debian/patches/series --- denemo-0.9.2/debian/patches/series 2011-10-04 16:35:55.000000000 -0600 +++ denemo-0.9.2/debian/patches/series 2012-08-14 07:44:27.000000000 -0600 @@ -3,3 +3,5 @@ Makefile.am.diff denemo.conf.diff configure.in.diff +glib-single-include.diff +format_error_strings.diff diff -Nru denemo-0.9.2/debian/rules denemo-0.9.2/debian/rules --- denemo-0.9.2/debian/rules 2011-10-04 16:35:55.000000000 -0600 +++ denemo-0.9.2/debian/rules 2012-08-14 07:44:27.000000000 -0600 @@ -7,6 +7,9 @@ %: dh $@ --with autoreconf +override_dh_auto_configure: + dh_auto_configure -- $(shell dpkg-buildflags --export=configure) + override_dh_fixperms: dh_fixperms # check if denemo-data (arch-all package) is being built
--- End Message ---
--- Begin Message ---On 15.08.2012 22:17, Josue Abarca wrote:Please unblock package denemo The last changes are based in the feedback that I got from: #684063 unblock: denemo/0.9.2-2 denemo/0.9.2-3 fixes: #665520 Including individual glib headers no longer supported #683563 Enable hardened build flags (Current version in testing: 0.9.2-1) denemo (0.9.2-3) unstable; urgency=low * Set the environment variables listed by dpkg-buildflags using a less intrusive approach: - debian/rules override_dh_auto_configure added to set the environment variables listed by dpkg-buildflags. - debian/compat changed from 9 to 7 - debian/control debhelper build dependency version reverted from 9 to 7.0.50~Unblocked; thanks. Regards, Adam
--- End Message ---
