The branch main has been updated by 0mp:

URL: 
https://cgit.FreeBSD.org/src/commit/?id=6567623f831daaffa67777d17780e8f424c1bb01

commit 6567623f831daaffa67777d17780e8f424c1bb01
Author:     Mateusz Piotrowski <0...@freebsd.org>
AuthorDate: 2025-07-14 23:09:24 +0000
Commit:     Mateusz Piotrowski <0...@freebsd.org>
CommitDate: 2025-07-15 21:07:13 +0000

    vfs_cache: Fix the SDT definition of vfs:fplookup:lookup:done
    
    1. The definition lists struct nameidata as the type of the first
       argument. However, the actual probes always pass a variable of type
       struct nameidata* to SDT_PROBE3.
    2. The third argument (args[2]) is actually enum cache_fpl_status.
    
    Reviewed by:    markj
    Approved by:    markj (mentor)
    Fixes:          07d2145a1717 vfs: add the infrastructure for lockless lookup
    MFC after:      1 week
    Differential Revision:  https://reviews.freebsd.org/D51315
---
 sys/kern/vfs_cache.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sys/kern/vfs_cache.c b/sys/kern/vfs_cache.c
index 3d455b3874cc..ec3f947ffa55 100644
--- a/sys/kern/vfs_cache.c
+++ b/sys/kern/vfs_cache.c
@@ -332,7 +332,8 @@ SDT_PROBE_DEFINE2(vfs, namecache, evict_negative, done, 
"struct vnode *",
     "char *");
 SDT_PROBE_DEFINE1(vfs, namecache, symlink, alloc__fail, "size_t");
 
-SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata", "int", 
"bool");
+SDT_PROBE_DEFINE3(vfs, fplookup, lookup, done, "struct nameidata *", "int",
+    "enum cache_fpl_status");
 SDT_PROBE_DECLARE(vfs, namei, lookup, entry);
 SDT_PROBE_DECLARE(vfs, namei, lookup, return);
 

Reply via email to