> On Sept. 21, 2015, 5:47 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, > > line 243 > > <https://reviews.apache.org/r/38567/diff/1/?file=1078494#file1078494line243> > > > > INSTALLED is also a state from which no transition is likely to happen. > > If the cluster version is INSTALLED, it means all host versions are > > INSTALLED too.
You are correct. I will add this logic. > On Sept. 21, 2015, 5:47 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, > > line 235 > > <https://reviews.apache.org/r/38567/diff/1/?file=1078494#file1078494line235> > > > > Should we do this only for the host_versions that this host has? The host was already removed by this point, so unless we also capture that information in the event and then do a bunch of comparisons I don't see how we would restrict it. Does it hurt to do it for all? - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38567/#review99826 ----------------------------------------------------------- On Sept. 21, 2015, 4:21 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38567/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2015, 4:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Nate Cole. > > > Bugs: AMBARI-13171 > https://issues.apache.org/jira/browse/AMBARI-13171 > > > Repository: ambari > > > Description > ------- > > During an upgrade, AMBARI-12924 and AMBARI-12889 allow for a host to be > placed into Maintenance Mode in order for it to be excluded from the upgrade. > Although there is work planned to be able to finalize an upgrade with hosts > that are in MM and out-of-sync, in the short term there also needs to be the > ability to remove these hosts so that finalization can complete. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/HostRemovedEvent.java > e005754 > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > 0824760 > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > 6ede46b > > ambari-server/src/main/java/org/apache/ambari/server/stack/MasterHostResolver.java > 62613ff > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java > eda2534 > > ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClustersImpl.java > 972ceec > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > b056991 > > Diff: https://reviews.apache.org/r/38567/diff/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Jonathan Hurley > >
