----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39513/#review103532 -----------------------------------------------------------
Ship it! Ship It! - Selim Ozcan On Oct. 21, 2015, 8:43 a.m., Selim Ozcan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39513/ > ----------------------------------------------------------- > > (Updated Oct. 21, 2015, 8:43 a.m.) > > > Review request for Ambari. > > > Bugs: https://issues.apache.org/jira/browse/AMBARI-13450 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/AMBARI-13450 > > > Repository: ambari > > > Description > ------- > > https://issues.apache.org/jira/browse/AMBARI-13450 > > > For the time being, bootstrapping cluster is done via default port number 22 > for SSH and SCP protocols without an option to specify the port number. > > There was a need to bootstrap cluster via different port number at the > laboratory which I work at but Apache Ambari didn't have that option so we > add that functionality. It still uses the default port number 22 unless you > change it at Installer Wizard Step 2. > > A Textfieldview (default written value '22' SSH Port number ) added to > installer wizard step 2, same as specifying ssh user field which is default > to 'root' user, to take the SSH port input from user. After that, Port number > is transferred to bootstrapping functions along with sshUser value. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/BSRunner.java > 0a55131 > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java > 822e972 > ambari-server/src/main/python/bootstrap.py 3eba75c > ambari-server/src/test/python/TestBootstrap.py e143a68 > ambari-web/app/controllers/wizard.js 2049099 > ambari-web/app/controllers/wizard/step2_controller.js 3b51761 > ambari-web/app/controllers/wizard/step3_controller.js b3645e9 > ambari-web/app/messages.js 349ae70 > ambari-web/app/styles/application.less 31d495e > ambari-web/app/templates/wizard/step2.hbs a194cc0 > ambari-web/test/controllers/wizard/step2_test.js d62b247 > ambari-web/test/controllers/wizard/step3_test.js 74c62e6 > > Diff: https://reviews.apache.org/r/39513/diff/ > > > Testing > ------- > > https://issues.apache.org/jira/browse/AMBARI-13450?focusedCommentId=14965976&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14965976 > > > ++1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12767586/diff_patch2.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > +1 tests included. The patch appears to include 3 new or modified test files. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-server ambari-web. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/4016//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/4016//console > > This message is automatically generated. > > > Thanks, > > Selim Ozcan > >
