Hello Pouria Pirzadeh, Jenkins,
I'd like you to reexamine a change. Please visit
https://asterix-gerrit.ics.uci.edu/334
to look at the new patch set (#2).
Change subject: 1. Fix the memory bloat issue introduced by
https://github.com/apache/incubator-asterixdb/commit/c66d23a5ac65ec5218ee47134aea423fd62a32cc
Recycle object pools in ADMDataParser before parsing each top-level ADM
record.
......................................................................
1. Fix the memory bloat issue introduced by
https://github.com/apache/incubator-asterixdb/commit/c66d23a5ac65ec5218ee47134aea423fd62a32cc
Recycle object pools in ADMDataParser before parsing each top-level ADM
record.
2. Avoid using Strings as parameters of object pools because string comparison
is slow and several comparisons done for parsing each ADM record.
Change-Id: I31848d8bd42a07f72035aefa2d671fdb2fce037d
---
M asterix-om/src/main/java/edu/uci/ics/asterix/builders/AbvsBuilderFactory.java
M asterix-om/src/main/java/edu/uci/ics/asterix/builders/ListBuilderFactory.java
M
asterix-om/src/main/java/edu/uci/ics/asterix/builders/RecordBuilderFactory.java
M
asterix-om/src/main/java/edu/uci/ics/asterix/om/pointables/nonvisitor/AListPointable.java
M
asterix-om/src/main/java/edu/uci/ics/asterix/om/pointables/nonvisitor/ARecordPointable.java
M
asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/evaluators/functions/records/RecordFieldsUtil.java
M
asterix-runtime/src/main/java/edu/uci/ics/asterix/runtime/operators/file/ADMDataParser.java
7 files changed, 91 insertions(+), 63 deletions(-)
git pull ssh://asterix-gerrit.ics.uci.edu:29418/asterixdb
refs/changes/34/334/2
--
To view, visit https://asterix-gerrit.ics.uci.edu/334
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I31848d8bd42a07f72035aefa2d671fdb2fce037d
Gerrit-PatchSet: 2
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Yingyi Bu <[email protected]>
Gerrit-Reviewer: Jenkins <[email protected]>
Gerrit-Reviewer: Pouria Pirzadeh <[email protected]>
Gerrit-Reviewer: Preston Carman <[email protected]>
