mneethiraj commented on a change in pull request #52: ATLAS-3203: Add parent
entity names to qualifiedName
URL: https://github.com/apache/atlas/pull/52#discussion_r298815528
##########
File path: webapp/src/test/java/org/apache/atlas/examples/QuickStartV2IT.java
##########
@@ -155,6 +157,25 @@ private void verifySimpleTableAttributes(AtlasEntity
table) {
assertEquals("sales fact table", tableAttributes.get("description"));
}
+ private void verifyQualifiedNames(AtlasEntity table) {
+ Map<String, Object> tableAttributes =
table.getRelationshipAttributes();
+ Map dbFromTable = (Map) tableAttributes.get("db");
+ String tableName = (String)
tableAttributes.get("name");
+ String dbName = (String) dbFromTable.get("name");
Review comment:
'dbFromTable' is an AtlasObjectId and wouldn't have all attributes of the DB
entity, hence dbName should be null here. Can you please confirm if this test
passes successfully?
Changes in QuickStartV2.java look good, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
