Hi, all If PR is used to fix issue, Reviewer should help contributer associate PR with issue. This will make others know that some one is working at this issue. This is what I found when I fixed https://github.com/apache/incubator-dubbo/issues/3420.
Ian Luo <ian....@gmail.com> 于2019年2月18日周一 下午5:59写道： > It happens but I believe it's rare. If it does happen, I agree with the > ideas Huxing proposed. > > Regards, > -Ian. > > On Mon, Feb 18, 2019 at 5:39 PM yuhang xiu <carry...@gmail.com> wrote: > > > Totally agree with huxing. > > In addition, we may be able to remind the authors of the two prs that > their > > pr is repeated. > > This will let them review the code and leave a comment. In some cases, > > perhaps one of them will close their pr directly. > > > > Huxing Zhang <hux...@apache.org> 于2019年2月18日周一 下午5:28写道： > > > > > Hi, > > > > > > I remember I've seen this kind of issue before. > > > > > > From my point of view, I prefer the following precedence: > > > - check the implementation, the code quality requirement should be > > > satisfied. > > > - if the quality looks more or less the same, I usually check if > > > he/she is the first time contributor. I think we should be more > > > generous to new comers. > > > > > > > Can't agree more. We should involve more people. Getting more people to > > contribute to dubbo is very important for the dubbo community, and we > > should give this opportunity to newcomer. > > > > > > > - if the above condition is not met, I tend to use FIFO based on the > > > creation time of the pull request. > > > > > > This is my personal opinion, let's see what others might think. > > > > > > To avoid this issue, I do recommend people to leave a comment before > > > start contributing. > > > > > > On Mon, Feb 18, 2019 at 2:03 PM Minxuan Zhuang <z82507...@gmail.com> > > > wrote: > > > > > > > > Hi Community, > > > > If two pull requests are aiming to solve the same issue, how to > > > choose > > > > from them? > > > > > > > > > > > > -- > > > Best Regards！ > > > Huxing > > > > > >
