jhsenjaliya commented on a change in pull request #2636: [GOBBLIN-766] Emit Workunits Created event URL: https://github.com/apache/incubator-gobblin/pull/2636#discussion_r284487478
########## File path: gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java ########## @@ -377,6 +378,13 @@ public void apply(JobListener jobListener, JobContext jobContext) jobState.setState(JobState.RunningState.COMMITTED); isWorkUnitsEmpty = true; return; + } else { Review comment: optional: how about reporting `workUnitsCreated=0` when there is no workUnits instead of reporting `WorkUnitsEmpty` event? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services