I committed fixes to master and 2.0.x for this issue which was an
off-by-one error when counting multipart parts.  I also committed two
test-only fixes but everything else looks good for rc2.  Sorry about the
dud rc1 but I am glad we caught this before release!

On Wed, Feb 07, 2018 at 10:37:20PM -0800, Andrew Gaul wrote:
> -1 due to failures in BaseBlobIntegrationTest.testPutMultipartByteSource
> across all blobstores.  Reverting
> d05be89614b4539b2ac16e911439dcb3df2e23df fixes these test failures.  I
> hope to look at this tomorrow to see if I can salvage the intended fix.
> 
> On Tue, Feb 06, 2018 at 10:50:42AM +0100, Ignasi Barrera wrote:
> > Hello,
> > 
> > This is the first release candidate for Apache jclouds 2.1.0.
> > 
> > Please use the separate [DISCUSS] thread for anything but votes.
> > 
> > It fixes the following issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > version=12334714&styleName=Html&projectId=12314430
> > 
> > *** Please download, test and vote by Friday, February 9th, 02:00 PST /
> > 05:00 EST / 11:00 CET.
> > 
> > Note that we are voting upon the source (tag), binaries are provided for
> > convenience.
> > 
> > Source and binary files:
> > https://dist.apache.org/repos/dist/dev/jclouds/2.1.0-rc1
> > 
> > Maven staging repo:
> > https://repository.apache.org/content/repositories/orgapachejclouds-1040
> > 
> > These are the tags to be voted upon:
> >   * jclouds
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds.git;a=tag;h=ae213ad7e8bf059fe8eaa570f7192b183bb33e75
> >     - sha-1: 431575787370551ebba260c235994c2c301538db
> >   * jclouds-labs
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds-labs.git;a=tag;h=efd1c06eef234978947282640621ac079d40a663
> >     - sha-1: 9e60307e022f10104a8f8f717a810239e7afa3ec
> >   * jclouds-labs-openstack
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-openstack.git;a=tag;h=c5ff2347fcf7c190afec6f985bf1cfd4f77be83b
> >     - sha-1: ba4c6938fab0c120e1a7c5ecfcd0ae2f3bcf4f66
> >   * jclouds-labs-aws
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds-labs-aws.git;a=tag;h=306bf2df875b26544989a287bd3bf49fe815fbf5
> >     - sha-1: ffec0de4e9ddee5b05c97e4fe186b29b1e2d09bc
> >   * jclouds-karaf
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds-karaf.git;a=tag;h=505a9803cbd8a1cb9e7217b0c316367560810ffe
> >     - sha-1: d029403b6ded54df9065a040eef4acd1be512c93
> >   * jclouds-cli
> >     - tag:
> > https://git-wip-us.apache.org/repos/asf?p=jclouds-cli.git;a=tag;h=9e3f7a5a0a0a3a6de7b7706ccc7fe262e7e2aec9
> >     - sha-1: e1f5fe2dff6bf448ba7d9116ec73230bffd88cca
> > 
> > 
> > jclouds KEYS file containing PGP keys we use to sign the release:
> > http://www.apache.org/dist/jclouds/KEYS
> > 
> > [ ] +1
> > [ ] 0  (explain why)
> > [ ] -1 (explain why)
> 
> -- 
> Andrew Gaul
> http://gaul.org/

> testPutMultipartByteSource(org.jclouds.azureblob.blobstore.integration.AzureBlobIntegrationLiveTest)
>   Time elapsed: 142.993 sec  <<< FAILURE!
> java.lang.AssertionError:
> InputStreams do not have equal content:
> line:<555781>, expected:<� `��]���5\�>������|�e���+nw�C]��SzA�����UU���9
>                                                                         
> ��{�c���@����oշX��fkY�� 
> ����^��U�c��o������Kg��CB��w�Q�٩E�E���8�h�G!�<����b��Xz��e�@��1���,65ψL�[z���{����R�������wT_������I���{�&���et���S��Z�x޻v��s�
>                                                                               
>                           ɧ�xe�����2�@]`��`�R�
>      O�ܟ�\o��K5��*do�.ݑ4��J=D�Q"��nW�+��F�!P�q����2��0��72{ue�/�EC��    
> �zW��FFRQ_X���C-�,�x��6z�C~�k�c�o�HG21O��6�x_�H���
>    '��> but was:<� `��]���5\�>������|�e���+nw�C]��SzA�����UU���9
>                                                                 
> ��{�c���@����oշX��fkY�� 
> ����^��U�c��o������Kg��CB��w�Q�٩E�E���8�h�G!�<����b��Xz��e�@��1���,65ψL�[z���{����R�������wT_������I���{�&���et���S��Z�x޻v��s�
>                                                                               
>                   ɧ�xe�����2�@]`��`�R�
>                                                                               
>                                       
> O�ܟ�\o��K5��*do�.ݑ4��J=D�Q"��nW�+��F�!P�q����2��0��72{ue�/�EC��    
> �zW��FFRQ_X���C-�,�>
> line:<555782>, expected:<%�Anք\����{a���3�G�Uk�쬽�⮌     �L�ڋÀz�
>                                                                
> ����Km;&�:���pׄ+%��ʽB$N> but was:<EOF>
>         at 
> org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPut(BaseBlobIntegrationTest.java:834)
>         at 
> org.jclouds.blobstore.integration.internal.BaseBlobIntegrationTest.testPutMultipartByteSource(BaseBlobIntegrationTest.java:677)
>         at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>         at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>         at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>         at java.lang.reflect.Method.invoke(Method.java:498)
>         at 
> org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:85)
>         at org.testng.internal.Invoker.invokeMethod(Invoker.java:696)
>         at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:882)
>         at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1189)
>         at 
> org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:124)
>         at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:108)
>         at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
>         at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
>         at java.lang.Thread.run(Thread.java:748)


-- 
Andrew Gaul
http://gaul.org/

Reply via email to