Am 2024-08-15 um 10:38 schrieb Konrad Windszus:
Hi,
I would appreciate some cleanup of the branches after
https://issues.apache.org/jira/browse/MPLUGIN-523.
I see now
1) master
2) mvn4
3) maven-plugin-tools-3.7.x
4) maven-plugin-tools-3.x
IIUC only 1 and 4 is relevant.
I agree, but I would leave this cleanup to gnodet@ since he knows the
differences best.
Also in 1) I see a lot of code not relevant for v4 plugins like
-
https://github.com/apache/maven-plugin-tools/tree/master/maven-plugin-annotations
-
https://github.com/apache/maven-plugin-tools/blob/9332b09acc08d2e063f12a8158a57ca8ec56fadd/maven-plugin-tools-generators/src/main/java/org/apache/maven/tools/plugin/generator/PluginDescriptorFilesGenerator.java#L114
(lots of guards related to v4)
And also in 4) I see a lot of code only relevant for v4 plugins:
-
https://github.com/apache/maven-plugin-tools/blob/f1acf76556e57632a36634f4ad683186786d4ed9/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/MojoAnnotationsScanner.java#L40
Was the intention of https://issues.apache.org/jira/browse/MPLUGIN-523 only the
creation of the branches without cleaning up the code?
gnodet@ again...
On 14. Aug 2024, at 17:47, Michael Osipov <micha...@apache.org> wrote:
Hi,
we solved 2 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12354665
There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%20resolution%20%3D%20Unresolved
Staging repo:
https://repository.apache.org/content/repositories/maven-2181/
https://repository.apache.org/content/repositories/maven-2181/org/apache/maven/plugin-tools/maven-plugin-tools/3.14.0/maven-plugin-tools-3.14.0-source-release.zip
Source release checksum(s):
maven-plugin-tools-3.14.0-source-release.zip
sha512:
70d63cf443fe6f44ed8e5faf6f031975203e31bef03d32c186dbfb10ab3728970111ca90c93d85283b5854b06bfee38d024f07f7fe42b6cee48a57de3004ace9
Staging site:
https://maven.apache.org/plugin-tools-archives/plugin-tools-LATEST/
Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html
Vote open for 72 hours.
[ ] +1
[ ] +0
[ ] -1
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@maven.apache.org
For additional commands, e-mail: dev-h...@maven.apache.org
