Hi all,
I want to ask is "EntityUtil.filterByAnd" a bug or done intentionally in the
following code snippet:
CheckoutHelper.processPayment:1026
Actaully it is not a big deal, this code will only aprove the order, but
this will happen only if we have "CASH", "EXT_COD", adnd "EXT_BILLACT"
payment method types in the order. And i donot know haw can i add these 3
types at once.
I think "EntityUtil.filterByAnd" in 1031 should be chaged to filterByOr
WDYT ?
} else {
// Get the paymentMethodTypeIds - this will need to change when
ecom supports multiple payments
List cashCodBaExpr = UtilMisc.toList(new
EntityExpr("paymentMethodTypeId", EntityOperator.EQUALS, "CASH"),
new
EntityExpr("paymentMethodTypeId", EntityOperator.EQUALS, "EXT_COD"),
new
EntityExpr("paymentMethodTypeId", EntityOperator.EQUALS, "EXT_BILLACT"));
List cashCodBaPaymentPreferences =
EntityUtil.filterByAnd(allPaymentPreferences, cashCodBaExpr);
if (UtilValidate.isNotEmpty(cashCodBaPaymentPreferences) &&
UtilValidate.isNotEmpty(allPaymentPreferences) &&
cashCodBaPaymentPreferences.size() ==
allPaymentPreferences.size()) {
// approve this as long as there are only CASH, COD and
Billing Account types
boolean ok = OrderChangeHelper.approveOrder(dispatcher,
userLogin, orderId, manualHold);
if (!ok) {
throw new GeneralException("Problem with order change;
see above error");
}
} else {
// There is nothing to do, we just treat this as a success
}
}
--
View this message in context:
http://www.nabble.com/Possible-bug-in-CheckoutHelper.processPayment-tf4669654.html#a13339382
Sent from the OFBiz - Dev mailing list archive at Nabble.com.
