[
https://issues.apache.org/jira/browse/OFBIZ-1712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12586551#action_12586551
]
Yin T commented on OFBIZ-1712:
------------------------------
I was thinking about this issue. It's more from a provider's perspective.
Should it not be the providers responsibility to remove the ".svn" subdirectory
when deploying Ofbiz? Was Ofbiz originally conceptualized to run as a complete
source tree along with source control information embedded in the directory
structure?
If it is not the case, then a simple modification to the "build.xml" to remove
the ".svn" subdirectories might be more appropriate.
Ideally speaking, skipping the ".svn" subdirectory would definitely improve the
startup time of the application.
Would like to get some opinions about this.
> Skip ".svn" subdirectories when searching for JAR files during ofbiz startup
> ----------------------------------------------------------------------------
>
> Key: OFBIZ-1712
> URL: https://issues.apache.org/jira/browse/OFBIZ-1712
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Environment: n/a
> Reporter: Yin T
> Priority: Trivial
> Attachments: start_filter_svn.patch
>
>
> During ofbiz startup, it looks for jar files in the /ofb/framework/base/lib.
> I noticed that when it is iterating through this subdirectory, it looks into
> the ".svn" subdirectory as well. This sub directory should be skipped.
> The files affected are shown below. I don't know why "CVS" string exists in
> the code. Perhaps its legacy code from way back.
> /ofbiz/framework/base/src/base/org/ofbiz/base/container/ComponentContainer.java,
> line 182
> change...
> if (componentPath.isDirectory() && !sub.equals("CVS")) {
> to...
> if (componentPath.isDirectory() && !sub.equals("CVS") &&
> !sub.equals(".svn")) {
> /ofbiz/framework/base/src/start/org/base/start/Start.java, line 174:
> change...
> if (file.isDirectory() && !"CVS".equals(fileName) && recurse) {
> to...
> if (file.isDirectory() && !"CVS".equals(fileName) &&
> !".svn".equals(fileName) && recurse) {
> ofbiz-trunk/framework/shark/webapp/shark/repository - showRepository.ftl
> There's an occurrence of "CVS" string as well. But I do not know
> Freemarker macros.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
