[ 
https://issues.apache.org/jira/browse/OFBIZ-1700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12670739#action_12670739
 ] 

Bruno Busco commented on OFBIZ-1700:
------------------------------------

Hi Jacopo,
please find hereafter how it should work in the different scenarios:

1) svn is not available: the build process should proceed without errors
- OK if svn is not available the and svn-info should not be invoked the build 
batch file should only call the "ant run-install" and not the "ant svninfo"

2) the ant svn plugin is not available (I think it is an optional lib): the 
build process should proceed without errors
- The patch does not use any ant svn plugin. It is based on a "exec" task that 
calls the "svn" command through the os shell

3) internate connection is not available when the ant target is invoked: the 
build process should proceed without errors
- Again the svninfo is a different task that should be called separately by a 
batch file. If the connection is not available, only this will fail and the svn 
version will be "unknoun"

4) evaluate possible license issues (if any) with the ant svn plugin
- Please see 2)

5) (as Tim mentioned) the trunk was exported instead of checked out
- Please see 1)

I agree, may be it is better to have and empty default value instead of the 
last proposed "Rev: unknown (run "ant svninfo" to show your version)"

OK, I think it is better to have it in runtime folder.

I will update the patch accordingly.


> To show Current Revision number of OFBiz on its home site that will facilate 
> in testing and comparing things with a local copy of OFBiz 
> ----------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: OFBIZ-1700
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-1700
>             Project: OFBiz
>          Issue Type: New Feature
>            Reporter: Vikas Mayur
>            Assignee: Jacques Le Roux
>         Attachments: about_app.zip, about_ss.JPG, screenshot1.png, 
> screenshot2.png, svninfo.patch, svninfo.patch, svninfo.patch, svninfo.patch, 
> svninfo_ss1.gif, svninfo_ss2.gif
>
>
>  We can put OFBiz Revision Number :
> 1) along with the Trunk and Release labels under Demo Sites section in OFBiz 
> home site (http://ofbiz.apache.org) . Refer to screenshot1
> 2) In the footer file. Refer to screenshot2 & a discussion started by Jacques 
> at http://www.nabble.com/Mention-of-version---in-release-to13078575.html

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to