[ 
https://issues.apache.org/jira/browse/OFBIZ-2948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759306#action_12759306
 ] 

Scott Gray commented on OFBIZ-2948:
-----------------------------------

If the object only lives for one service call, how is that any different that 
using a static method?  Also you should do a check to see if the method is 
static before creating an instance of the class.

Even if this does get committed (I'm not entire convinced it should be), it 
shouldn't go into 9.04


> A minor change in org.ofbiz.service.engine.StandardJavaEngine
> -------------------------------------------------------------
>
>                 Key: OFBIZ-2948
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-2948
>             Project: OFBiz
>          Issue Type: Wish
>    Affects Versions: Release Branch 9.04
>         Environment: FC10 + OpenJDK 1.6
>            Reporter: Shi Yusen
>            Priority: Trivial
>             Fix For: Release Branch 9.04
>
>
> Change
>             result = m.invoke(null, dctx, context);
> to
>             result = m.invoke(c.newInstance(), dctx, context);
> This change will make it possible to invoke both static method and instance 
> method. See 
> http://java.sun.com/j2se/1.5.0/docs/api/java/lang/reflect/Method.html#invoke(java.lang.Object,%20java.lang.Object...).
> I've tested this in OFBiz 9.04 and works fine.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to