Why should we always have the same HTML markup? I might want padding
inside the screenlet in some cases, other times not. There are many
examples of this in the project.
I don't see where it affects CSS. Right now we have a descendant
selector that styles the body if it exists. What is being made easier?
-Adrian
Bruno Busco wrote:
Adrian,
I think we should have always the same HTML markup regardless of how
it has been obtained: a screenlet widget rendering, a containers
sequence rendering of even and FTL file (as we have in this case).
Since there no means of putting the screenlet content outside of the
screenlet-body tag, I think we should always have it there even when
we are able to do it by using an FTL file.
This makes the HTML more consistent and the life easier to CSS.
If we need to have more room for a special screenlet we could use a
special style and work on the CSS.
-Bruno
2009/10/8 Adrian Crum <adri...@hlmksw.com>:
Bruno,
The "defacto" standard that has been used so far is to eliminate the
screenlet body in screenlets that contain tables. The idea is to leave more
room for the table contents, plus have any grid lines extend to the
screenlet border.
-Adrian
bus...@apache.org wrote:
Author: buscob
Date: Thu Oct 8 17:30:56 2009
New Revision: 823237
URL: http://svn.apache.org/viewvc?rev=823237&view=rev
Log:
Added missing "screenlet-body" tag
Modified:
ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl
Modified:
ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl
URL:
http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl?rev=823237&r1=823236&r2=823237&view=diff
==============================================================================
---
ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl
(original)
+++
ofbiz/trunk/framework/webtools/webapp/webtools/service/availableservices.ftl
Thu Oct 8 17:30:56 2009
@@ -365,26 +365,28 @@
<div class="screenlet-title-bar">
<h3>${uiLabelMap.WebtoolsServicesListFor}
${dispatcherName?default(uiLabelMap.CommonNA)} (${servicesFoundCount}
${uiLabelMap.CommonFound})</h3>
</div>
- <table class="basic-table hover-bar" cellspacing='0'>
- <tr class="header-row">
- <td>${uiLabelMap.WebtoolsServiceName}</td>
- <td>${uiLabelMap.WebtoolsEngineName}</td>
- <td>${uiLabelMap.WebtoolsDefaultEntityName}</td>
- <td>${uiLabelMap.WebtoolsInvoke}</td>
- <td>${uiLabelMap.WebtoolsLocation}</td>
- </tr>
- <#assign alt_row = false>
- <#list servicesList as service>
- <tr<#if alt_row> class="alternate-row"</#if>>
- <td><a
href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td>
- <td><a
href='<@ofbizUrl>${url}?constraint=engine_n...@${service.enginename?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td>
- <td><a
href='<@ofbizUrl>${url}?constraint=default_entity_n...@${service.defaultentityname?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td>
- <td>${service.invoke}</td>
- <td><a
href='<@ofbizUrl>${url}?constraint=locat...@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td>
+ <div class="screenlet-body">
+ <table class="basic-table hover-bar" cellspacing='0'>
+ <tr class="header-row">
+ <td>${uiLabelMap.WebtoolsServiceName}</td>
+ <td>${uiLabelMap.WebtoolsEngineName}</td>
+ <td>${uiLabelMap.WebtoolsDefaultEntityName}</td>
+ <td>${uiLabelMap.WebtoolsInvoke}</td>
+ <td>${uiLabelMap.WebtoolsLocation}</td>
</tr>
- <#assign alt_row = !alt_row>
- </#list>
- </table>
+ <#assign alt_row = false>
+ <#list servicesList as service>
+ <tr<#if alt_row> class="alternate-row"</#if>>
+ <td><a
href='<@ofbizUrl>${url}?sel_service_name=${service.serviceName}</@ofbizUrl>'>${service.serviceName}</a></td>
+ <td><a
href='<@ofbizUrl>${url}?constraint=engine_n...@${service.enginename?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.engineName}</a></td>
+ <td><a
href='<@ofbizUrl>${url}?constraint=default_entity_n...@${service.defaultentityname?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.defaultEntityName}</a></td>
+ <td>${service.invoke}</td>
+ <td><a
href='<@ofbizUrl>${url}?constraint=locat...@${service.location?default(uiLabelMap.CommonNA)}</@ofbizUrl>'>${service.location}</a></td>
+ </tr>
+ <#assign alt_row = !alt_row>
+ </#list>
+ </table>
+ </div>
</div>
<#else>
${uiLabelMap.WebtoolsNoServicesFound}.
