[
https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reopened OFBIZ-3425:
------------------------------------
Hi Sascha,
Adam remarked on the dev ML that your patch was not well formatted and
especially asked why you used a Double instead of a double as parameter?
For formatting have a look at coding conventions in [Contributors Best
Practices|http://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+Contributors+Best+Practices]
In you case, mostly spaces after and before if and {, but anyway read the
document on [coding
conventions|http://cwiki.apache.org/confluence/display/OFBADMIN/Coding+Conventions]
Then please submit another patch. Obviously I'd been easier for me to do it
(and I could have done it when I commited your patch, if I had spotted them)
but as says the proverb "It's better to learn somebody to fish then to give him
a fish" ;)
Thanks
> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
> Key: OFBIZ-3425
> URL: https://issues.apache.org/jira/browse/OFBIZ-3425
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods,
> maybe it can help.
> Have a nice Day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
