[
https://issues.apache.org/jira/browse/OFBIZ-3425?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-3425.
----------------------------------
Resolution: Fixed
Hi Sascha,
Actually your last patch (OFBIZ-3425_getPropertyNumberDefaultValue.patch) still
miss the right spacing. But anyway, I had a look at the class and I formatted
getPropertyNumber as is getPropertyValue.
This is still questionnable if you look at the Sun conventions. They do not
allow exceptions with the "brackets around blocks rule". But in OFBiz you will
see some places where it's actually done. Like for instance in getPropertyValue
from where I copied the formatting to format getPropertyNumber. I have asked
that, and the convention in the OFBiz community is to bypass this rule in low
level tools, where you are sure nothing will change later. Some break it also
elsewhere, but I'd not recommend it.
In other word, please read carefully the Sun coding conventions document when
you get chances and try to follow them as much as possible. Most of the time
you will find good examples around the code you are changing. For instance
here, you would have just followed how getPropertyValue was formatted.
Commited at r903571
Thanks for your effort
> Extend getPropertyNumber, Defualt Value
> ---------------------------------------
>
> Key: OFBIZ-3425
> URL: https://issues.apache.org/jira/browse/OFBIZ-3425
> Project: OFBiz
> Issue Type: Improvement
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Sascha Rodekamp
> Assignee: Jacques Le Roux
> Fix For: SVN trunk
>
> Attachments: getPropertyNumberDefaultValue.patch,
> OFBIZ-3425_getPropertyNumberDefaultValue.patch
>
>
> Hi,
> i added a method to add a defualt value to the getPropertyNumber methods,
> maybe it can help.
> Have a nice Day
> Sascha
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
