You are correct. I didn't realize that pflatten was a cheat (plus scary comment in apr_brigade_pflatten: 'XXX This is dangerous beyond belief..'). I thought it didn't call apr_brigade_length, but did flatten at one pass. I should have looked at the source. Sorry about that.
np. I guess we both need to learn to shoot less from the hip... or lighten up a bit :)
Well, if you did look at apr_brigade_pflatten and you knew that it does a double pass already, why didn't you say so in reponse to my "inefficiency" comment? Remember, I wasn't working on this code and was just giving comments to your patch.
apr_brigade_pflatten should now get a different modifier than ~ in apr_functions.map.
why? it's implemented, no?
kinda. I guess my thought is that if it has a ~ then it means that it's implemented proper - there's no pflatten() method anywhere now. but the maps are more of a guideline anyway for non-autogenerated stuff, so it's no biggie.
I can't see why do you suggest that apr_brigade_pflatten doesn't have a proper implementation. $bb->flatten() is the proper implementation, no?
Dunno, may be we need a new marker that says that this function is implemented but may be named differently?
at any rate, at least we now have something that works.
;)
__________________________________________________________________ Stas Bekman JAm_pH ------> Just Another mod_perl Hacker http://stason.org/ mod_perl Guide ---> http://perl.apache.org mailto:[EMAIL PROTECTED] http://use.perl.org http://apacheweek.com http://modperlbook.org http://apache.org http://ticketmaster.com
--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
