[
https://issues.apache.org/jira/browse/PIG-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13065460#comment-13065460
]
Dmitriy V. Ryaboy commented on PIG-2115:
----------------------------------------
Sorry for the long wait.
This looks fine, but stylistically, I don't see a reason for the "import
static" construct being used. The use of import static is discouraged by its
own documentation
(http://download.oracle.com/javase/1.5.0/docs/guide/language/static-import.html
-- see "when should I use import static"), because it makes it unclear where a
given method is implemented.
> Pig HBaseStorage configuration and setup issues
> -----------------------------------------------
>
> Key: PIG-2115
> URL: https://issues.apache.org/jira/browse/PIG-2115
> Project: Pig
> Issue Type: Bug
> Affects Versions: 0.9.0
> Reporter: Greg Bowyer
> Labels: hbase, load, storage
> Attachments: HBaseStorage-correctly-configure-child-MapR-task-v1.patch
>
>
> HBase storage currently configures child MapR jobs assuming that the HBase
> jars and cluster configuration are present on the hadoop cluster that will
> run the pig program. In some circumstances, and for some configurations this
> causes problems with both the configuration suddenly becoming defaulted
> during a job run as well as ClassNotFound exceptions occurring due to the
> child MapReduce job being incorrectly configured.
> As such, the hbase built in configuration is merged with the job
> configuration using the inbuilt pig classes for this functionality, this
> prevents the jobs configuration from being overwritten by defaults.
> At the same time this change has been mirrored in the relevant setup methods
> called when the HBaseStorage is used as a StoreFunc; this means that the
> StoreFunc also correctly sets up the relevant classpath preventing
> ClassNotFound exceptions in clusters that are not adding the HBase classes to
> the HADOOP_CLASSPATH.
> Attached is a patch that hopefully fixes these issues for others.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
