kumaab commented on code in PR #253:
URL: https://github.com/apache/ranger/pull/253#discussion_r1190726336


##########
security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java:
##########
@@ -863,6 +868,49 @@ public void deleteXUserByUserName(@PathParam("userName") 
String userName,
                xUserMgr.deleteXUser(vxUser.getId(), forceDelete);
        }
 
+
+       /**
+        * Proceed with caution: Force deletes users in bulk from the ranger db,
+        * essentially serves as a cleanup Op for external users.
+        * <tt>Delete</tt> happens one at a time with immediate commit on the 
transaction.
+        */
+       @DELETE
+       @Path("/delete/external/users")
+       @PreAuthorize("hasRole('ROLE_SYS_ADMIN')")
+       @Produces({ "application/json" })
+       public Response deleteXUsers() {

Review Comment:
   thanks for the suggestion, changes included in the latest patch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@ranger.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to