diff -r 3b212497130f st.c --- a/st.c Fri Nov 19 17:13:13 2010 +0100 +++ b/st.c Sat Nov 20 18:21:31 2010 +0100 @@ -131,20 +131,17 @@ char s[ESC_BUF_SIZ]; } Key; -typedef struct { - XFontSet fs; - short lbearing; - short rbearing; - int ascent; - int descent; -} FontInfo; - /* Drawing Context */ typedef struct { unsigned long col[256]; - FontInfo font; - FontInfo bfont; GC gc; + struct { + int ascent; + int descent; + short lbearing; + short rbearing; + XFontSet set; + } font, bfont; } DC; /* TODO: use better name for vars... */ @@ -222,10 +219,10 @@ static void selcopy(void); static void selpaste(void); -static int stou(char *, long *); -static int utos(long *, char *); -static int slen(char *); -static int canstou(char *, int); +static int utf8decode(char *, long *); +static int utf8encode(long *, char *); +static int utf8size(char *); +static int isfullutf8(char *, int); static void (*handler[LASTEvent])(XEvent *) = { [KeyPress] = kpress, @@ -254,8 +251,7 @@ static char *opt_title = NULL; static char *opt_class = NULL; -/* UTF-8 decode */ -static int stou(char *s, long *u) { +static int utf8decode(char *s, long *u) { unsigned char c; int i, n, rtn; @@ -293,8 +289,7 @@ return rtn; } -/* UTF-8 encode */ -static int utos(long *u, char *s) { +static int utf8encode(long *u, char *s) { unsigned char *sp; unsigned long uc; int i, n; @@ -329,34 +324,30 @@ /* use this if your buffer is less than UTF_SIZ, it returns 1 if you can decode UTF-8 otherwise return 0 */ -static int canstou(char *s, int b) { - unsigned char c = *s; - int n; +static int isfullutf8(char *s, int b) { + unsigned char *c1, *c2, *c3; - if (b < 1) + c1 = (unsigned char *) s; + c2 = (unsigned char *) ++s; + c3 = (unsigned char *) ++s; + if(b < 1) return 0; - else if (~c&B7) - return 1; - else if ((c&(B7|B6|B5)) == (B7|B6)) - n = 1; - else if ((c&(B7|B6|B5|B4)) == (B7|B6|B5)) - n = 2; - else if ((c&(B7|B6|B5|B4|B3)) == (B7|B6|B5|B4)) - n = 3; - else - return 1; - for (--b,++s; n>0&&b>0; --n,--b,++s) { - c = *s; - if ((c&(B7|B6)) != B7) - break; - } - if (n > 0 && b == 0) + else if((*c1&(B7|B6|B5)) == (B7|B6) && b == 1) + return 0; + else if((*c1&(B7|B6|B5|B4)) == (B7|B6|B5) && + ((b == 1) || + ((b == 2) && (*c2&(B7|B6)) == B7))) + return 0; + else if((*c1&(B7|B6|B5|B4|B3)) == (B7|B6|B5|B4) && + ((b == 1) || + ((b == 2) && (*c2&(B7|B6)) == B7) || + ((b == 3) && (*c2&(B7|B6)) == B7 && (*c3&(B7|B6)) == B7))) return 0; else return 1; } -static int slen(char *s) { +static int utf8size(char *s) { unsigned char c = *s; if (~c&B7) @@ -415,7 +406,7 @@ for(y = 0; y < term.row; y++) { for(x = 0; x < term.col; x++) if(term.line[y][x].state & GLYPH_SET && (ls = selected(x, y))) { - sl = slen(term.line[y][x].c); + sl = utf8size(term.line[y][x].c); memcpy(ptr, term.line[y][x].c, sl); ptr += sl; } @@ -629,9 +620,9 @@ die("Couldn't read from shell: %s\n", SERRNO); else { buflen += ret; - for(ptr=buf; buflen>=UTF_SIZ||canstou(ptr,buflen); buflen-=br) { - br = stou(ptr, &u); - utos(&u, s); + for(ptr=buf; buflen>=UTF_SIZ||isfullutf8(ptr,buflen); buflen-=br) { + br = utf8decode(ptr, &u); + utf8encode(&u, s); tputc(s); ptr += br; } @@ -1458,49 +1449,63 @@ XSetWMProperties(xw.dis, xw.win, NULL, NULL, NULL, 0, &size, &wm, &class); } +XFontSet +xinitfont(char *fontstr) +{ + XFontSet set; + char *def, **missing; + int n; + + missing = NULL; + set = XCreateFontSet(xw.dis, fontstr, &missing, &n, &def); + if(missing) { + while(n--) + fprintf(stderr, "st: missing fontset: %s\n", missing[n]); + XFreeStringList(missing); + } + return set; +} + void -xsetfontinfo(FontInfo *fi) +xgetfontinfo(XFontSet set, int *ascent, int *descent, short *lbearing, short *rbearing) { XFontStruct **xfonts; - int fnum; - int i; - char **fontnames; + char **font_names; + int i, n; - fi->lbearing = 0; - fi->rbearing = 0; - fi->ascent = 0; - fi->descent = 0; - fnum = XFontsOfFontSet(fi->fs, &xfonts, &fontnames); - for(i=0; iascent < (*xfonts)->ascent) - fi->ascent = (*xfonts)->ascent; - if(fi->descent < (*xfonts)->descent) - fi->descent = (*xfonts)->descent; - if(fi->rbearing < (*xfonts)->max_bounds.rbearing) - fi->rbearing = (*xfonts)->max_bounds.rbearing; - if(fi->lbearing < (*xfonts)->min_bounds.lbearing) - fi->lbearing = (*xfonts)->min_bounds.lbearing; + *ascent = *descent = *lbearing = *rbearing = 0; + n = XFontsOfFontSet(set, &xfonts, &font_names); + for(i = 0; i < n; i++) { + *ascent = MAX(*ascent, (*xfonts)->ascent); + *descent = MAX(*descent, (*xfonts)->descent); + *lbearing = MAX(*lbearing, (*xfonts)->min_bounds.lbearing); + *rbearing = MAX(*rbearing, (*xfonts)->max_bounds.rbearing); + xfonts++; } } void +initfonts(char *fontstr, char *bfontstr) +{ + if((dc.font.set = xinitfont(fontstr)) == NULL || + (dc.bfont.set = xinitfont(bfontstr)) == NULL) + die("Can't load font %s\n", dc.font.set ? BOLDFONT : FONT); + xgetfontinfo(dc.font.set, &dc.font.ascent, &dc.font.descent, + &dc.font.lbearing, &dc.font.rbearing); + xgetfontinfo(dc.bfont.set, &dc.bfont.ascent, &dc.bfont.descent, + &dc.bfont.lbearing, &dc.bfont.rbearing); +} + +void xinit(void) { XSetWindowAttributes attrs; - char **mc; - char *ds; - int nmc; if(!(xw.dis = XOpenDisplay(NULL))) die("Can't open display\n"); xw.scr = XDefaultScreen(xw.dis); /* font */ - if ((dc.font.fs = XCreateFontSet(xw.dis, FONT, &mc, &nmc, &ds)) == NULL || - (dc.bfont.fs = XCreateFontSet(xw.dis, BOLDFONT, &mc, &nmc, &ds)) == NULL) - die("Can't load font %s\n", dc.font.fs ? BOLDFONT : FONT); - xsetfontinfo(&dc.font); - xsetfontinfo(&dc.bfont); + initfonts(FONT, BOLDFONT); /* XXX: Assuming same size for bold font */ xw.cw = dc.font.rbearing - dc.font.lbearing; @@ -1562,7 +1567,7 @@ XSetForeground(xw.dis, dc.gc, xfg); if(base.mode & ATTR_GFX) - for(i = 0; i < cl; i++) { + for(i = 0; i < sl; i++) { char c = gfx[(unsigned int)s[i] % 256]; if(c) s[i] = c; @@ -1570,7 +1575,7 @@ s[i] -= 0x5f; } - XmbDrawImageString(xw.dis, xw.buf, base.mode & ATTR_BOLD ? dc.bfont.fs : dc.font.fs, + XmbDrawImageString(xw.dis, xw.buf, base.mode & ATTR_BOLD ? dc.bfont.set : dc.font.set, dc.gc, winx, winy, s, sl); if(base.mode & ATTR_UNDERLINE) @@ -1592,14 +1597,14 @@ /* remove the old cursor */ if(term.line[oldy][oldx].state & GLYPH_SET) { - sl = slen(term.line[oldy][oldx].c); + sl = utf8size(term.line[oldy][oldx].c); xdraws(term.line[oldy][oldx].c, term.line[oldy][oldx], oldx, oldy, 1, sl); } else xclear(oldx, oldy, oldx, oldy); /* draw the new one */ if(!(term.c.state & CURSOR_HIDE) && (xw.state & WIN_FOCUSED)) { - sl = slen(g.c); + sl = utf8size(g.c); xdraws(g.c, g, term.c.x, term.c.y, 1, sl); oldx = term.c.x, oldy = term.c.y; } @@ -1609,7 +1614,7 @@ /* basic drawing routines */ void xdrawc(int x, int y, Glyph g) { - int sl = slen(g.c); + int sl = utf8size(g.c); XRectangle r = { x * xw.cw, y * xw.ch, xw.cw, xw.ch }; XSetBackground(xw.dis, dc.gc, dc.col[g.bg]); XSetForeground(xw.dis, dc.gc, dc.col[g.fg]); @@ -1661,7 +1666,7 @@ ox = x; base = new; } - sl = slen(new.c); + sl = utf8size(new.c); memcpy(buf+ib, new.c, sl); ib += sl; ++ic;