[ 
https://issues.apache.org/jira/browse/THRIFT-948?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14484071#comment-14484071
 ] 

Roger Meier commented on THRIFT-948:
------------------------------------

Please align whitespace/ spaces with existing code and do not put some file 
references to joel hacker within comments.
And some test cases would be beneficial as well, we have some test certificates 
and keys located at test/keys/

> SSL socket support for PHP
> --------------------------
>
>                 Key: THRIFT-948
>                 URL: https://issues.apache.org/jira/browse/THRIFT-948
>             Project: Thrift
>          Issue Type: New Feature
>          Components: PHP - Library
>            Reporter: David Reiss
>            Priority: Minor
>         Attachments: php-ssl-0.9.2.patch, php-ssl.patch
>
>
> This had some basic testing, but was never used in production.  If someone 
> wants to implement this feature, they can start with this patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to