Github user okram commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/279#issuecomment-201909772
@pietermartin -- From just a code review, everything looks really clean and
consistent with the conventions thus far. You added to `traversal.asciidoc`,
you created a `GroovyOptionalTest` and an `OptionalTest`. Your test cases good.
Finally, you were smart about adding `__.optional()`. Did my
`GraphTraversalTest` open your eyes :) ?.
Please make sure the docs build. Better yet, `publish-docs.sh` after your
`process-docs.sh` and then we can all see the new section online. Finally,
please do a full integration test. If you can paste your `BUILD SUCCESSFUL`
console output of your integration test run, that would be great. After that,
I will vote.
Thank you Pieter.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
