On 12/10/19 10:10 AM, Laszlo Ersek wrote:
On 12/10/19 09:35, Rabeda, Maciej wrote:
Ok, Jiaxin :)
Mike, Laszlo, Liming,
Do you know who I should contact in regards to maintainership role
transition (edk2 write access etc.)?
Write access directly to the edk2 repo has been revoked from
maintainers.
Documentation updates are underway by Mike, to my understanding. Please
see the following threads:
- [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master
E92EE9817A31E24EB0585FDF735412F5B9E173A1@ORSMSX113.amr.corp.intel.com">http://mid.mail-archive.com/E92EE9817A31E24EB0585FDF735412F5B9E173A1@ORSMSX113.amr.corp.intel.com
https://edk2.groups.io/g/devel/message/50407
- [edk2-devel] [Patch wiki v2] EDK II CI: Update Phase 1 details and admin
settings
20191202175630.12788-1-michael.d.kinney@intel.com">http://mid.mail-archive.com/20191202175630.12788-1-michael.d.kinney@intel.com
https://edk2.groups.io/g/devel/message/51556
- [edk2-devel] [Patch wiki v2] EDK II Dev Process: Change push to GitHub pull
request
http://mid.mail-archive.com/20191202180131.876-1-michael.d.kinney@intel.com
https://edk2.groups.io/g/devel/message/51557
For a brief (personal, informal) summary, I can offer (quoting an email
I sent earlier):
- prepare a local topic branch, on top of master, with the review tags
in place, such that (per the earlier method) you'd ff-push that topic
branch as the new edk2 master.
- instead of pushing it to edk2, push it to your personal edk2 repo on
github.com
- log in to github.com, and initiate a pull request against edk2/master,
from your personal topic branch
You should be able to work without browser, using the hub tool such:
$ sudo dnf install hub
$ hub pull-request \
--base tianocore:master \
--head lersek:next \
--edit \
-F - < pull-request-template.md
(see https://hub.github.com/hub-pull-request.1.html)
I haven't audited the tool, so if you are worried about using it on your
workstation, the web interface is certainly safer :)
There is a Docker image based on Debian:
https://hub.docker.com/r/tianon/github-hub/dockerfile
$ podman pull tianon/github-hub
~/source/edk2$ podman run -v $PWD:$PWD -w $PWD tianon/github-hub
usage: git [--version] [--help] [-C <path>] [-c name=value]
[--exec-path[=<path>]] [--html-path] [--man-path] [--info-path]
[-p | --paginate | --no-pager] [--no-replace-objects] [--bare]
[--git-dir=<path>] [--work-tree=<path>] [--namespace=<name>]
<command> [<args>]
However it seems still incomplete:
~/source/edk2$ docker run \
--rm \
--volume $PWD:$PWD \
--volume $HOME/.gitconfig:$HOME/.gitconfig:ro \
--volume $HOME/.config/edk2:$HOME/.config/edk2:ro \
--volume $HOME/.config:/config:ro \
--workdir $PWD \
--user $UID \
tianon/github-hub \
hub issue
mkdir /.config: permission denied
So apparently this expects root privileges within container meaning it
will access host files with that privileges too, which I'm not ready to
accept.
- as soon as the pull request has been filed, locate the "labels" box to
the right, and apply the "push" label.
Once the CI tests complete, the branch will be merged (fast-forwarded).
The official description will be in the wiki, containing even
screenshots. See the third reference above, from Mike. For now, those
updates can be seen rendered in Mike's clone of the Wiki, namely at
<https://github.com/mdkinney/edk2/wiki/EDK-II-Development-Process>.
Thanks
Laszlo
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#52082): https://edk2.groups.io/g/devel/message/52082
Mute This Topic: https://groups.io/mt/67501831/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
